Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colours to GitHub dashboard metric visualisations #6857

Merged

Conversation

yenienserrano
Copy link
Member

Description

Add colours to the metric visualisations on the GitHub dashboard with the 3 colors allowed for such visualisations.

Issues Resolved

Evidence

image

Test

  1. Navigate to Github > Dashboard
  2. Check the colors of the metrics visualizations

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this Jul 19, 2024
@yenienserrano yenienserrano linked an issue Jul 19, 2024 that may be closed by this pull request
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.64% ( 3989 / 29232 )
Branches 9.1% ( 1744 / 19151 )
Functions 13.35% ( 943 / 7063 )
Lines 13.83% ( 3886 / 28094 )

@Desvelao
Copy link
Member

Tests

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
Navigate to Github > Dashboard. Check the colors of the metrics visualizations 🟢

Details

🟢 Navigate to Github > Dashboard. Check the colors of the metrics visualizations

Chrome - 🟢
image

Firefox - ⚫

Safari - ⚫

@Machi3mfl Machi3mfl self-requested a review July 22, 2024 10:52
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Machi3mfl
Copy link
Member

Tests

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
Navigate to Github > Dashboard. Check the colors of the metrics visualizations 🟢

Details

🟢 Navigate to Github > Dashboard. Check the colors of the metrics visualizations

Chrome - 🟢

Screenshot 2024-07-22 at 08 06 31

Firefox - ⚫

Safari - ⚫

@Desvelao Desvelao merged commit 8db579a into 4.9.0 Jul 22, 2024
5 checks passed
@Desvelao Desvelao deleted the bug/6856-add-colours-to-github-dashboard-visualisations branch July 22, 2024 12:59
@asteriscos asteriscos mentioned this pull request Aug 21, 2024
74 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add colours to github Dashboard visualisations
3 participants