Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rule.mitre_techniques column from the Threat Hunting #6858

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Remove rule.mitre_techniques column from the Threat Hunting #6858

merged 1 commit into from
Jul 23, 2024

Conversation

chantal-kelm
Copy link
Member

@chantal-kelm chantal-kelm commented Jul 22, 2024 •
edited by Desvelao
Loading

Description

Remove rule.mitre_techniques column from the Threat Hunting

Issues Resolved

#6830

Evidence

image

Test

  • Go to the Threat Hunting module and verify that the field rule.mitre_techniques does not appear in the table on the Dashboard tab.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@chantal-kelm chantal-kelm self-assigned this Jul 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.64% ( 3989 / 29229 )
Branches 9.1% ( 1744 / 19151 )
Functions 13.35% ( 943 / 7061 )
Lines 13.83% ( 3886 / 28091 )

@chantal-kelm chantal-kelm linked an issue Jul 22, 2024 that may be closed by this pull request
Some links in the Threat Hunting dashboard table do not redirect or have no links #6830
Closed
@Desvelao
Copy link
Member

🟢 Test

image

Desvelao
Desvelao approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Desvelao Desvelao merged commit d988e4a into 4.9.0 Jul 23, 2024
5 checks passed
@Desvelao Desvelao deleted the bug/6830-remove-rule-mitre-techniques-column-from-the-threat-hunting branch July 23, 2024 12:34
@asteriscos asteriscos mentioned this pull request Aug 5, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao approved these changes

Assignees

@chantal-kelm chantal-kelm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some links in the Threat Hunting dashboard table do not redirect or have no links
2 participants
@chantal-kelm @Desvelao