Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking the internal tab when changing agent on FIM > Inventory > Windows registry #6880

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Jul 29, 2024

Description

Solution to change tab from Windows registry to Files when you have an agent pinned with windows and you switch to a non-windows agent.

Issues Resolved

Evidence

Screen.Recording.2024-07-29.at.3.10.28.PM.mov

Preconditions

Have 2 agents 1 windows and 1 from another operating system connected

Test

  1. Navigate to 'FIM > Inventory > Windows registry'
  2. Change the pinned agent to the one of the other operating system
  3. Windows registry tab should be changed for Files

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this Jul 29, 2024
@chantal-kelm chantal-kelm self-requested a review July 29, 2024 13:49
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

image

Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.63% ( 3990 / 29261 )
Branches 9.12% ( 1746 / 19137 )
Functions 13.34% ( 943 / 7065 )
Lines 13.82% ( 3887 / 28125 )

Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Screen.Recording.2024-07-29.at.14.41.00.mov

@lucianogorza lucianogorza merged commit da9d55f into 4.9.0 Jul 29, 2024
5 checks passed
@lucianogorza lucianogorza deleted the 6879-the-inventory-table-remains-in-registry-when-the-agent-is-changed branch July 29, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The inventory table remains in registry when the agent is changed.
4 participants