Fixes redirects to specific techniques #6882

yenienserrano · 2024-07-29T18:50:00Z

Description

Fixes the back button when navigating to a specific rule.mitre.id from events

The view is controlled by the parameters of the url to have more control of the back button.

Changed 2 pie charts to donut charts for application consistency.

Issues Resolved

Back button does not work when navigating from events to a specific rule.mitre.id #6881

Evidence

Uploading Screen Recording 2024-07-30 at 4.50.25 PM.mov…

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test	Chrome	Firefox	Safari
Navigate from Mitre > Events selecting data from the rule.mitre.id column, once in the flyout you should be able to press the back button and it should work.	⚫	⚫	⚫
navigate between the different tabs of Mitre > intelligence you must change the tabRedirect url parameter	⚫	⚫	⚫
When navigating in Mitre > intelligence view the back button should work.	⚫	⚫	⚫
If the rabRedirect parameter is not present when rendering the view, the parameter must be added.	⚫	⚫	⚫

Details

⚫ Navigate from Mitre > Events selecting data from the rule.mitre.id column, once in the flyout you should be able to press the back button and it should work.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ navigate between the different tabs of Mitre > intelligence you must change the tabRedirect url parameter

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ When navigating in Mitre > intelligence view the back button should work.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ If the rabRedirect parameter is not present when rendering the view, the parameter must be added.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

All tests pass
- yarn test:jest
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

…igating-from-events-to-a-specific-rulemitreid

chantal-kelm

Grabacion.de.pantalla.2024-07-30.a.la.s.1.57.41.p.m.mov

Grabacion.de.pantalla.2024-07-30.a.la.s.1.59.44.p.m.mov

plugins/main/public/components/overview/mitre/intelligence/intelligence.tsx

jbiset

CR: 🟡

Test UI: 🟡

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test	Chrome	Firefox	Safari
Navigate from Mitre > Events selecting data from the rule.mitre.id column, once in the flyout you should be able to press the back button and it should work.	🟢	🟢	⚫
navigate between the different tabs of Mitre > intelligence you must change the tabRedirect url parameter	🟢	🟢	⚫
When navigating in Mitre > intelligence view the back button should work.	🟢	🟢	⚫
If the rabRedirect parameter is not present when rendering the view, the parameter must be added.	🟡	⚫	⚫

Details

🟢 Navigate from Mitre > Events selecting data from the rule.mitre.id column, once in the flyout you should be able to press the back button and it should work.

Chrome - 🟢

Evidence_1_Chrome.webm

Firefox - 🟢

Evidence_1_Firefox.webm

Safari - ⚫

🟢 navigate between the different tabs of Mitre > intelligence you must change the tabRedirect url parameter

Chrome - 🟢

Evidence_2_Chrome.webm

Firefox - 🟢

Evidence_2_Firefox.webm

Safari - ⚫

🟢 When navigating in Mitre > intelligence view the back button should work.

Chrome - 🟢

Evidence_3_Chrome.webm

Firefox - 🟢

Evidence_3_Firefox.webm

Safari - ⚫

🟡 If the tabRedirect parameter is not present when rendering the view, the parameter must be added.

NOTE: Since the effect in charge of adding tabRedirect if it is not alone is executed on the first render. If the URL is changed after the component has already been rendered, the effect does not run.

Chrome - 🟡

Evidence_tabRedirect_yellow.webm

Firefox - ⚫ :

Safari - ⚫

plugins/main/public/components/overview/mitre/intelligence/intelligence.tsx

Desvelao · 2024-07-31T08:26:34Z

Using the search bar on the left panel, the tabRedirect parameter is not modified

Another use case:

Select a resource type from the left menu (groups, mitigations, etc...)
Use the search bar and ensure the search is done
Select a resource type from the left menu (groups, mitigations, etc...)
Clicking again on the selected resource, causes the view with the current search is displayed.

Navigating from the Intelligence tab to another tab on the the MITRE ATT&CK module does not remove the tabRedirect query parameter on the URL.

These behaviors should be synced with the URL.

plugins/main/public/components/overview/mitre/intelligence/resources.tsx

…igating-from-events-to-a-specific-rulemitreid

yenienserrano · 2024-07-31T13:07:14Z

Using the search bar on the left panel, the tabRedirect parameter is not modified

Another use case:

Select a resource type from the left menu (groups, mitigations, etc...)

Use the search bar and ensure the search is done

Select a resource type from the left menu (groups, mitigations, etc...)

Clicking again on the selected resource, causes the view with the current search is displayed.

Navigating from the Intelligence tab to another tab on the the MITRE ATT&CK module does not remove the tabRedirect query parameter on the URL.

These behaviors should be synced with the URL.

Currently this is the behavior that the application is having in other views, and due to lack of time it cannot be modified in this edition either.

…igating-from-events-to-a-specific-rulemitreid

github-actions · 2024-07-31T16:29:30Z

Wazuh Core plugin code coverage (Jest) test	%	values
Statements	45.96%	( 399 / 868 )
Branches	41.97%	( 157 / 374 )
Functions	44.01%	( 136 / 309 )
Lines	46.16%	( 397 / 860 )

github-actions · 2024-07-31T16:29:35Z

Wazuh Check Updates plugin code coverage (Jest) test	%	values
Statements	76.44%	( 172 / 225 )
Branches	58.65%	( 61 / 104 )
Functions	61.7%	( 29 / 47 )
Lines	76.44%	( 172 / 225 )

github-actions · 2024-07-31T16:34:04Z

Main plugin code coverage (Jest) test	%	values
Statements	13.68%	( 4003 / 29260 )
Branches	9.12%	( 1747 / 19137 )
Functions	13.37%	( 945 / 7067 )
Lines	13.86%	( 3900 / 28126 )

Machi3mfl

UI

Test	Chrome	Firefox	Safari
Navigate from Mitre > Events selecting data from the rule.mitre.id column, once in the flyout you should be able to press the back button and it should work.	🟢	⚫	⚫
navigate between the different tabs of Mitre > intelligence you must change the tabRedirect url parameter	🟢	⚫	⚫
When navigating in Mitre > intelligence view the back button should work.	🟢	⚫	⚫
If the rabRedirect parameter is not present when rendering the view, the parameter must be added.	🟢	⚫	⚫

Details

🟢 Navigate from Mitre > Events selecting data from the rule.mitre.id column, once in the flyout you should be able to press the back button and it should work.

Chrome - 🟢

Screen.Recording.2024-07-31.at.13.35.17.mov

Firefox - ⚫

Safari - ⚫

🟢 navigate between the different tabs of Mitre > intelligence you must change the tabRedirect url parameter

Chrome - 🟢

Screen.Recording.2024-07-31.at.13.36.27.mov

Firefox - ⚫

Safari - ⚫

🟢 When navigating in Mitre > intelligence view the back button should work.

Chrome - 🟢

Screen.Recording.2024-07-31.at.13.37.27.mov

Firefox - ⚫

Safari - ⚫

🟢 If the rabRedirect parameter is not present when rendering the view, the parameter must be added.

Chrome - 🟢

Screen.Recording.2024-07-31.at.13.40.29.mov

Firefox - ⚫

Safari - ⚫

jbiset

CR: 🟢

Test UI: 🟢

🟢 If the rabRedirect parameter is not present when rendering the view, the parameter must be added.

Chrome - 🟢

Evidence_change_URL_Chrome.webm

Firefox - 🟢

Evidence_change_URL_Firefox.webm

Safari - ⚫

🟢 Changed 2 pie charts to donut charts for application consistency.

Chrome - 🟢

Firefox - 🟢

Safari - ⚫

Add switch route to flyout

70d47df

yenienserrano self-assigned this Jul 29, 2024

yenienserrano linked an issue Jul 29, 2024 that may be closed by this pull request

Back button does not work when navigating from events to a specific rule.mitre.id #6881

Closed

yenienserrano added 2 commits July 30, 2024 13:25

Merge branch '4.9.0' into bug/6881-back-buttom-does-not-work-when-nav…

b5b43f2

…igating-from-events-to-a-specific-rulemitreid

Merge branch '4.9.0' into bug/6881-back-buttom-does-not-work-when-nav…

a2376bb

…igating-from-events-to-a-specific-rulemitreid

yenienserrano marked this pull request as draft July 30, 2024 11:40

yenienserrano added 4 commits July 30, 2024 16:37

Update redirections

3d45aa0

Add tabRedirect to know subTab

b30952a

Update changelog

fb56878

Fix(intelligence test): Mock service

2a61e3b

yenienserrano marked this pull request as ready for review July 30, 2024 15:22

chantal-kelm self-requested a review July 30, 2024 17:00

chantal-kelm previously approved these changes Jul 30, 2024

View reviewed changes

jbiset reviewed Jul 30, 2024

View reviewed changes

plugins/main/public/components/overview/mitre/intelligence/intelligence.tsx Outdated Show resolved Hide resolved

jbiset reviewed Jul 30, 2024

View reviewed changes

Desvelao reviewed Jul 31, 2024

View reviewed changes

plugins/main/public/components/overview/mitre/intelligence/intelligence.tsx Outdated Show resolved Hide resolved

Desvelao reviewed Jul 31, 2024

View reviewed changes

plugins/main/public/components/overview/mitre/intelligence/resources.tsx Show resolved Hide resolved

Merge branch '4.9.0' into bug/6881-back-buttom-does-not-work-when-nav…

833be9c

…igating-from-events-to-a-specific-rulemitreid

yenienserrano dismissed chantal-kelm’s stale review via 833be9c July 31, 2024 10:13

yenienserrano added 3 commits July 31, 2024 14:54

Fix(intelligence): Fix comment

bc8a973

Change(Visualizations): Change donut: true

4b79664

Fix(tableColumnsCreator): remove parameter unused

4cd1b26

yenienserrano and others added 2 commits July 31, 2024 16:15

Merge branch '4.9.0' into bug/6881-back-buttom-does-not-work-when-nav…

8a7ca20

…igating-from-events-to-a-specific-rulemitreid

Merge branch '4.9.0' into bug/6881-back-buttom-does-not-work-when-nav…

3aa9c90

…igating-from-events-to-a-specific-rulemitreid

Machi3mfl approved these changes Jul 31, 2024

View reviewed changes

jbiset approved these changes Jul 31, 2024

View reviewed changes

lucianogorza merged commit ede74fd into 4.9.0 Jul 31, 2024
5 checks passed

lucianogorza deleted the bug/6881-back-buttom-does-not-work-when-navigating-from-events-to-a-specific-rulemitreid branch July 31, 2024 17:05

asteriscos mentioned this pull request Aug 5, 2024

Release 4.9.0 - Beta 1 - Wazuh UI regression testing #6897

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes redirects to specific techniques #6882

Fixes redirects to specific techniques #6882

yenienserrano commented Jul 29, 2024 •

edited

Loading

chantal-kelm left a comment •

edited

Loading

jbiset left a comment •

edited

Loading

Desvelao commented Jul 31, 2024 •

edited

Loading

yenienserrano commented Jul 31, 2024

github-actions bot commented Jul 31, 2024

github-actions bot commented Jul 31, 2024

github-actions bot commented Jul 31, 2024

Machi3mfl left a comment •

edited

Loading

jbiset left a comment

Fixes redirects to specific techniques #6882

Fixes redirects to specific techniques #6882

Conversation

yenienserrano commented Jul 29, 2024 • edited Loading

Description

Issues Resolved

Evidence

Test

UI

Check List

chantal-kelm left a comment • edited Loading

Choose a reason for hiding this comment

jbiset left a comment • edited Loading

Choose a reason for hiding this comment

CR: 🟡

Test UI: 🟡

UI

Desvelao commented Jul 31, 2024 • edited Loading

yenienserrano commented Jul 31, 2024

github-actions bot commented Jul 31, 2024

github-actions bot commented Jul 31, 2024

github-actions bot commented Jul 31, 2024

Machi3mfl left a comment • edited Loading

Choose a reason for hiding this comment

UI

jbiset left a comment

Choose a reason for hiding this comment

CR: 🟢

Test UI: 🟢

yenienserrano commented Jul 29, 2024 •

edited

Loading

chantal-kelm left a comment •

edited

Loading

jbiset left a comment •

edited

Loading

Desvelao commented Jul 31, 2024 •

edited

Loading

Machi3mfl left a comment •

edited

Loading