Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed render bug in security alerts table #6883

Merged
merged 5 commits into from
Jul 31, 2024
Merged

Fixed render bug in security alerts table #6883

merged 5 commits into from
Jul 31, 2024

Conversation

JuanGarriuz
Copy link
Member

@JuanGarriuz JuanGarriuz commented Jul 30, 2024 •
edited by Desvelao
Loading

Description

rule.mitre.id and rule.mitre.tactics is removed because the table fails if the data displayed in the table does not contain those values, it does not render.

Issues Resolved

Evidence

image

Test

Need sample data or real values

  • Go to Endpoint security > Malware Detection check that Security Alerts table shows values.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@JuanGarriuz JuanGarriuz linked an issue Jul 30, 2024 that may be closed by this pull request
Security alerts do not show anything in the Malware detection #6834
Closed
@JuanGarriuz JuanGarriuz self-assigned this Jul 30, 2024
Desvelao
Desvelao reviewed Jul 30, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@JuanGarriuz JuanGarriuz changed the title Security alerts do not show anything in the Malware detection Fixed render bug in Security alerts table Jul 30, 2024
Desvelao
Desvelao previously approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yenienserrano yenienserrano self-requested a review July 31, 2024 13:12
yenienserrano
yenienserrano approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

image

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.65% ( 3994 / 29259 )
Branches 9.12% ( 1746 / 19133 )
Functions 13.34% ( 943 / 7068 )
Lines 13.83% ( 3891 / 28123 )

@lucianogorza lucianogorza merged commit 9690855 into 4.9.0 Jul 31, 2024
5 checks passed
@lucianogorza lucianogorza deleted the bug/security-alerts-in-malware-detection-dont-render branch July 31, 2024 14:14
@asteriscos asteriscos changed the title Fixed render bug in Security alerts table Fixed render bug in security alerts table Aug 5, 2024
@asteriscos asteriscos mentioned this pull request Aug 5, 2024
Closed
1 task
@asteriscos asteriscos mentioned this pull request Aug 21, 2024
Closed
74 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@Desvelao Desvelao Desvelao left review comments

Assignees

@JuanGarriuz JuanGarriuz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Security alerts do not show anything in the Malware detection
4 participants
@JuanGarriuz @Desvelao @yenienserrano @lucianogorza