-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error generating dashboard reports on Firefox #6902
Fix error generating dashboard reports on Firefox #6902
Conversation
- Add dom-to-image-more dependency - Replace the library to generate de screenshots of the dashboard visualizations - Apply a fix related to cropped screenshots on Firefox
I will try to research what is happening on dark mode, but there is an issue that could be related: #3805 The visualization included on the PDF reports does not include the table of The quality of the visualization could be related to taking the screenshot. I initially added some code that scaled the visualization x2 and this had more resolution on the report, but using this approach causes a problem with the visualization related with KPIs. This was seen with @yenienserrano. |
…o fix/6900-error-generate-dashboard-reports-on-firefox
Findings on #6902 (comment)
|
TestIMPORTANT: Test acceptance criteria: test with Google Chrome (or variant), Firefox and Safari. Legend: UI
Details 🟢 Go to the Malware Detection > Dashboard and generate a report. It should contain the visualizations with an acceptable renderChrome - ⚫ Firefox - 🟢 Safari - 🟢 🟢 Go to the File Integrity Monitoring > Dashboard and generate a report. It should contain the visualizations with an acceptable renderChrome - ⚫ Firefox - 🟢 Safari - 🟢 🟢 Go to the Threat Hunting > Dashboard and generate a report. It should contain the visualizations with an acceptable renderChrome - ⚫ Firefox - 🟢 Safari - 🟢 🟢 Go to the MITRE ATT&CK > Dashboard and generate a report. It should contain the visualizations with an acceptable renderChrome - ⚫ Firefox - 🟢 Safari - 🟢 🟢 Go to the VirusTotal > Dashboard and generate a report. It should contain the visualizations with an acceptable renderChrome - ⚫ Firefox - 🟢 Safari - 🟢 🟢 Go to the PCI DSS > Dashboard and generate a report. It should contain the visualizations with an acceptable renderChrome - ⚫ Firefox - 🟢 Safari - 🟢 🟢 Go to the GDPR > Dashboard and generate a report. It should contain the visualizations with an acceptable renderChrome - ⚫ Firefox - 🟢 Safari - 🟢 🟢 Go to the HIPAA > Dashboard and generate a report. It should contain the visualizations with an acceptable renderChrome - ⚫ Firefox - 🟢 Safari - 🟢 🟢 Go to the NIST 800-53 > Dashboard and generate a report. It should contain the visualizations with an acceptable renderChrome - ⚫ Firefox - 🟢 Safari - 🟢 🟢 Go to the TSC > Dashboard and generate a report. It should contain the visualizations with an acceptable renderChrome - ⚫ Firefox - 🟢 Safari - 🟢 🟢 Go to the Docker > Dashboard and generate a report. It should contain the visualizations with an acceptable renderChrome - ⚫ Firefox - 🟢 Safari - 🟢 : 🟢 Go to the Amazon Web Services > Dashboard and generate a report. It should contain the visualizations with an acceptable renderChrome - ⚫ Firefox - 🟢 Safari - 🟡 maps without information 🟢 Go to the Google Cloud > Dashboard and generate a report. It should contain the visualizations with an acceptable renderChrome - ⚫ Firefox - 🟢 Safari - 🟢 🟢 Go to the GitHub > Dashboard and generate a report. It should contain the visualizations with an acceptable renderChrome - ⚫ Firefox - 🟢 Safari - 🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ations of HIPAA and NIST 800-53 applications
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
76f43a8
|
|
|
Description
This pull request fixes an error generating the dashboard reports using the Firefox web browser.
Changes:
dom-to-image-more
(v3.3.1) dependencyvisualizations
dom-to-image
dependencyIssues Resolved
#6900
Evidence
Firefox
Amazon Web Services:
Threat Hunting
Google Chrome
Amazon Web Services
Threat Hunting
Test
IMPORTANT: Test acceptance criteria: test with Google Chrome (or variant), Firefox and Safari.
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
Details
⚫ Go to the Malware Detection > Dashboard and generate a report. It should contain the visualizations with an acceptable render
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Go to the File Integrity Monitoring > Dashboard and generate a report. It should contain the visualizations with an acceptable render
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Go to the Threat Hunting > Dashboard and generate a report. It should contain the visualizations with an acceptable render
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Go to the MITRE ATT&CK > Dashboard and generate a report. It should contain the visualizations with an acceptable render
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Go to the VirusTotal > Dashboard and generate a report. It should contain the visualizations with an acceptable render
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Go to the PCI DSS > Dashboard and generate a report. It should contain the visualizations with an acceptable render
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Go to the GDPR > Dashboard and generate a report. It should contain the visualizations with an acceptable render
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Go to the HIPAA > Dashboard and generate a report. It should contain the visualizations with an acceptable render
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Go to the NIST 800-53 > Dashboard and generate a report. It should contain the visualizations with an acceptable render
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Go to the TSC > Dashboard and generate a report. It should contain the visualizations with an acceptable render
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Go to the Docker > Dashboard and generate a report. It should contain the visualizations with an acceptable render
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Go to the Amazon Web Services > Dashboard and generate a report. It should contain the visualizations with an acceptable render
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Go to the Google Cloud > Dashboard and generate a report. It should contain the visualizations with an acceptable render
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Go to the GitHub > Dashboard and generate a report. It should contain the visualizations with an acceptable render
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Go to the Office 365 > Dashboard and generate a report. It should contain the visualizations with an acceptable render
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
Check List
yarn test:jest