-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed agent RBAC filters from dashboard queries #6945
Removed agent RBAC filters from dashboard queries #6945
Conversation
* Fix 4.9.0 changelog * Remove 6519 reverted pull request
* Bump 4.9.0 revision 06 RC1 * Format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test
Grabacion.2024-08-22.105042.mp4
LGTM!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: 🟡
There are quite a few changes in the CHANGELOG that are not known to be correct because nothing is mentioned in the PR about them.
The change in this PR is not visible in the CHANGELOG
Test UI: 🟢
Remove allowed agents filters on data source 🟢
Remove allowed agents state from redux appStateReducers 🟢
Remove allowed agents filters on reporting (wz-reporting) 🟢
evidence_report.webm
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
Description
Remove all use of RBAC filters such as
agents allowed
.Closes #6943
Remove allowed agents filters on data source
Before
After
Remove allowed agents state from redux appStateReducers
Note
This method is placed on WzAuthorization and is used on every login.
This adds the allowed agent's list on the app state
Before
Screen.Recording.2024-08-26.at.12.30.00.mov
After
Remove allowed agents filters on reporting (wz-reporting)
Note
extendedInformation
Before
After
Note
Test all module reports
Screen.Recording.2024-08-27.at.15.54.57.mov
Check List
yarn test:jest