Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vulnerabilities Detection and Office 365 links to agent menu on Endpoints Summary #6983

Merged
merged 6 commits into from
Sep 11, 2024

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Sep 10, 2024

Description

This pull request adds the Vulnerabilities detection and Office 365 links to the agent menu on the Endpoints summary application and fixes a problem of missing options depending on the agent operating system in the agent configuration report.

Side changes:

  • Enhance the definition and management of unsupported modules by the agent operating system

Issues Resolved

#6972

Evidence

image

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
With a Windows agent, go to agent overview from Endpoints Summary and ensure the Vulnerabilities detection and Office 365 links appear in the agent menu
With a Linux agent, go to agent overview from Endpoints Summary and ensure the Vulnerabilities detection and Office 365 links appear in the agent menu
With a Linux agent, go to agent configuration, click on Export PDF button and ensure the Docker listener and OpenSCAP option appear

Details

⚫ With a Windows agent, go to agent overview from Endpoints Summary and ensure the Vulnerabilities detection and Office 365 links appear in the agent menu

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ With a Linux agent, go to agent overview from Endpoints Summary and ensure the Vulnerabilities detection and Office 365 links appear in the agent menu

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ With a Linux agent, go to agent configuration, click on Export PDF button and ensure the Docker listener and OpenSCAP option appear

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Desvelao Desvelao self-assigned this Sep 10, 2024
@Desvelao Desvelao linked an issue Sep 10, 2024 that may be closed by this pull request
- Fix vulnerabilities detection unsupported component by agent OS
- Replace the varible used to define the unsupported component for
  Docker
- Add unsupported module Office 365 to SunOS and "Others" OS
- Fix bug on the available options on the agent configuration report
@Desvelao Desvelao changed the title Add Vulnerabilities Detection link to agent menu on Endpoints Summary Add Vulnerabilities Detection and Office 365 links to agent menu on Endpoints Summary Sep 10, 2024
@Desvelao Desvelao marked this pull request as ready for review September 10, 2024 09:45
@Machi3mfl Machi3mfl self-requested a review September 10, 2024 11:12
@guidomodarelli
Copy link
Contributor

guidomodarelli commented Sep 10, 2024

CR 🟢

🟢 With a Windows agent, go to agent overview from Endpoints Summary and ensure the Vulnerabilities detection and Office 365 links appear in the agent menu

image

🟢 With a Linux agent, go to agent overview from Endpoints Summary and ensure the Vulnerabilities detection and Office 365 links appear in the agent menu

image

🟢 With a Linux agent, go to agent configuration, click on Export PDF button and ensure the Docker listener and OSCAP option appear

image

image

Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests

Test Chrome Firefox Safari
With a Windows agent, go to agent overview from Endpoints Summary and ensure the Vulnerabilities detection and Office 365 links appear in the agent menu 🟢
With a Linux agent, go to agent overview from Endpoints Summary and ensure the Vulnerabilities detection and Office 365 links appear in the agent menu 🟢
With a Linux agent, go to agent configuration, click on Export PDF button and ensure the Docker listener and OSCAP option appear 🟢

Details

🟢 With a Windows agent, go to agent overview from Endpoints Summary and ensure the Vulnerabilities detection and Office 365 links appear in the agent menu

Chrome - 🟢

Screenshot 2024-09-10 at 09 01 22

Firefox - ⚫

Safari - ⚫

🟢 With a Linux agent, go to agent overview from Endpoints Summary and ensure the Vulnerabilities detection and Office 365 links appear in the agent menu

Chrome - 🟢

Screenshot 2024-09-10 at 08 42 41

Firefox - ⚫

Safari - ⚫

🟢 With a Linux agent, go to agent configuration, click on Export PDF button and ensure the Docker listener and OSCAP option appear

Chrome - 🟢

Screenshot 2024-09-10 at 09 04 37

Firefox - ⚫

Safari - ⚫

Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 46.02% ( 400 / 869 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.22% ( 398 / 861 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.59% ( 4016 / 29540 )
Branches 9.09% ( 1755 / 19302 )
Functions 13.31% ( 947 / 7113 )
Lines 13.77% ( 3914 / 28424 )

@Desvelao Desvelao merged commit 67bcbe0 into 4.9.1 Sep 11, 2024
5 checks passed
@Desvelao Desvelao deleted the bug/6972-add-vulnerability-detection-agent-menu branch September 11, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent's Vulnerability section missing in 4.9.0
3 participants