Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Containers have different margins #7034

Merged
merged 12 commits into from
Oct 14, 2024
Merged

Containers have different margins #7034

merged 12 commits into from
Oct 14, 2024

Conversation

guidomodarelli
Copy link
Contributor

@guidomodarelli guidomodarelli commented Sep 30, 2024 •
edited
Loading

Description

Feature containers have different margins between them and the top containers. We want a design on which the containers separations are homogeneous

Issues Resolved

#7027

Evidence

image

Test

Navigate to the overview page and ensure to check the margins.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@guidomodarelli guidomodarelli mentioned this pull request Sep 30, 2024
Closed
6 tasks
@guidomodarelli guidomodarelli self-assigned this Sep 30, 2024
@guidomodarelli guidomodarelli linked an issue Sep 30, 2024 that may be closed by this pull request
Improve the overview page #7027
Closed
6 tasks
Machi3mfl
Machi3mfl previously approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Screenshot 2024-09-30 at 2 10 11 PM Screenshot 2024-09-30 at 2 09 48 PM

@guidomodarelli guidomodarelli force-pushed the enhancement/7027-containers-have-different-margins branch from 383d34f to 031499d Compare October 1, 2024 13:58
@guidomodarelli guidomodarelli force-pushed the enhancement/7027-containers-have-different-margins branch from 031499d to 0332dc6 Compare October 1, 2024 20:20
chantal-kelm
chantal-kelm previously approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
TEST: ✅

Captura de pantalla 2024-10-01 a la(s) 6 10 22 p  m Captura de pantalla 2024-10-01 a la(s) 6 06 04 p  m

asteriscos

This comment was marked as outdated.

Sign in to view

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 14.1% ( 4172 / 29576 )
Branches 9.23% ( 1779 / 19261 )
Functions 13.79% ( 985 / 7141 )
Lines 14.29% ( 4070 / 28462 )

@Tostti Tostti merged commit 12159dc into 4.10.0 Oct 14, 2024
5 checks passed
@Tostti Tostti deleted the enhancement/7027-containers-have-different-margins branch October 14, 2024 13:49
@asteriscos asteriscos mentioned this pull request Oct 21, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao left review comments

@asteriscos asteriscos asteriscos approved these changes

@Machi3mfl Machi3mfl Machi3mfl approved these changes

@chantal-kelm chantal-kelm chantal-kelm left review comments

Assignees

@guidomodarelli guidomodarelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the overview page
6 participants
@guidomodarelli @Machi3mfl @asteriscos @Desvelao @chantal-kelm @Tostti