-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add frontend state service #7037
Open
Desvelao
wants to merge
32
commits into
master
Choose a base branch
from
enhancement/6959-extract-common-services-frontend-state
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add frontend state service #7037
Desvelao
wants to merge
32
commits into
master
from
enhancement/6959-extract-common-services-frontend-state
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create state service based on AppState from main plugin - Create state containers - server_host - server_host_cluster_info - data_source_alerts - Add documentation for state service
6 tasks
6 tasks
- Remove unused methods: - AppState.setCreatedAt - AppState.getCreatedAt - AppState.getAPISelector - AppState.getPatternSelector - AppState.setPatternSelector (no-effect) - Remove usage of AppState.setPatternSelector because this has no effect in the current application
…bed when the plugin stops - Remove console.log - Dispatch new values when remove from the state containers
plugins/wazuh-core/public/services/state/containers/server-host-cluster-info.ts
Show resolved
Hide resolved
plugins/wazuh-core/public/services/state/containers/server-host-cluster-info.ts
Show resolved
Hide resolved
plugins/wazuh-core/public/services/state/containers/data-source-alerts.ts
Show resolved
Hide resolved
plugins/wazuh-core/public/services/state/containers/server-host-cluster-info.ts
Show resolved
Hide resolved
plugins/wazuh-core/public/services/state/containers/data-source-alerts.ts
Outdated
Show resolved
Hide resolved
plugins/wazuh-core/public/services/state/containers/server-host.ts
Outdated
Show resolved
Hide resolved
plugins/wazuh-core/public/services/state/containers/server-host-cluster-info.ts
Outdated
Show resolved
Hide resolved
plugins/wazuh-core/public/services/state/containers/data-source-alerts.ts
Outdated
Show resolved
Hide resolved
…to enhancement/6959-extract-common-services-frontend-state
Co-authored-by: Guido Modarelli <38738725+guidomodarelli@users.noreply.github.com>
…' of https://github.com/wazuh/wazuh-kibana-app into enhancement/6959-extract-common-services-frontend-state
Co-authored-by: Guido Modarelli <38738725+guidomodarelli@users.noreply.github.com>
…to enhancement/6959-extract-common-services-frontend-state
…back function in index-patterns.ts
…only-class in app-state.js
…e interfaces in state and services types files
…c-only-class in wz-api-check.js
… scoping standards across the project
…wz-api-check.js to improve code readability and flow
…s for better clarity and type safety in creator.tsx
…type safety in state management functionalities
… robustness in state management functionality
…rror for better clarity in data source alerts handling
…r clearer messages in server host cluster info handling
…larity with explicit Error casting in server host state management
guidomodarelli
previously approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
guidomodarelli
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
|
|
|
|
yenienserrano
requested changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a
state
service to thewazuh-core
plugin and expose it in the plugin lifecycle methods.The
state
service manages the shared state of the Wazuh plugins and it is a HUB of state containers. Features:The state containers provides a mechanism to manage a specific state. For example, some data is stored in cookies, others could be managed in-memory, local storage, session storage.
Others plugins can register new state containers.
The service creates hooks and HOCs that are exposed through the plugin lifecycle.
The
state
services is based onAppState
old service:Issues Resolved
#6959
Check List
yarn test:jest