Improve loading speed #7099
Closed
Improve loading speed #7099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
…ant variable assignment.- Remove commented out code for checking API parameters.- Simplify logic for handling missing API data
Desvelao
reviewed
Oct 30, 2024
Desvelao
reviewed
Oct 31, 2024
Desvelao
reviewed
Oct 31, 2024
| export interface WazuhPluginSetup {} | ||
|
|
||
| export interface WazuhPluginStart {} | ||
|
|
||
| export type PluginSetup = { | ||
| securityDashboards?: {}; // TODO: Add OpenSearch Dashboards Security interface | ||
| wazuhCore: {}; | ||
| wazuhCore: WazuhCore; |
There was a problem hiding this comment.
nitpick: this should use the type of wazuhCore plugin instead of defining a type in the wazuh plugin
Desvelao
reviewed
Oct 31, 2024
Desvelao
reviewed
Oct 31, 2024
…end optimizations for reduced latency. #7099
…unnecessary compilerOptions for clarity
… in configuration settings
|
|
|
|
The proposed changes don't provide a significant improvement in the loading performance. We will analyze a deep refactor in a different issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The primary objective is to enhance the application's initial load time.
I have made modifications to the backend endpoints following a comprehensive analysis of network performance during the application's initial load. These endpoints were identified as the primary contributors to latency. However, the impact of these changes may be negligible, as they primarily represent micro-optimizations rather than substantial improvements.
Issues Resolved
Closes #7084
Evidence
/check-stored-apiBEFORE
Average of 620 ms
AFTER
Average of 578 ms
/check-apiBEFORE
Average of 739,5 ms
AFTER
Average of 674 ms
Test
Open DevTools, navigate to the Application tab, and click on "Clear site data".
Right-click the reload page button, then select "Empty Cache and Hard Reload."
Repeat these steps:
Peek.2024-10-15.13-59.mp4
Check List
yarn test:jest