Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filter by value in document details in safari #7151

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Nov 13, 2024

Description

Filters on event flyouts were not appearing in safari

Issues Resolved

Evidence

Safari image
Firefox image
Chrome image

Test

  1. Navigate to "Threat Hunting"
  2. Go to the Events tab
  3. Click on the open row details
  4. Hover in a row

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this Nov 13, 2024
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 14.93% ( 4443 / 29756 )
Branches 9.79% ( 1886 / 19255 )
Functions 14.69% ( 1056 / 7186 )
Lines 15.14% ( 4337 / 28628 )

@Machi3mfl Machi3mfl self-requested a review November 14, 2024 14:38
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Chrome

Screen.Recording.2024-11-14.at.11.46.20.AM.mov

Safari

Screen.Recording.2024-11-14.at.11.45.25.AM.mov

Firefox

Screen.Recording.2024-11-14.at.11.47.29.AM.mov

Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

Peek 2024-11-14 17-35

@asteriscos asteriscos merged commit 76f81c4 into 4.10.0 Nov 14, 2024
5 checks passed
@asteriscos asteriscos deleted the bug/26825-filter-by-value-in-document-details-doesnt-appears-in-safari branch November 14, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter by value in document details doesn't appears in Safari
3 participants