Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder sections and rename endpoint groups #7161

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Reorder sections and rename endpoint groups #7161

merged 3 commits into from
Nov 14, 2024

Conversation

chantal-kelm
Copy link
Member

Description

Reorder sections and rename endpoint groups

Issues Resolved

#7148

Evidence

image

Test

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@chantal-kelm chantal-kelm self-assigned this Nov 14, 2024
@chantal-kelm chantal-kelm linked an issue Nov 14, 2024 that may be closed by this pull request
Fix endpoint group module name and indexer management order #7148
Closed
2 tasks
guidomodarelli
guidomodarelli previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@guidomodarelli guidomodarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend:
⚫: The test hasn't started yet
🟢: All checks passed.
🟡: There is at least one expected fail or skipped test and no failures.
🔴: There is at least one failed check.
⚪: Doesn't apply

CR 🟢
TEST 🟢

image

yenienserrano
yenienserrano previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

@yenienserrano yenienserrano dismissed stale reviews from guidomodarelli and themself via ce63269 November 14, 2024 16:43
yenienserrano
yenienserrano previously approved these changes Nov 14, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 14.91% ( 4436 / 29751 )
Branches 9.79% ( 1886 / 19250 )
Functions 14.69% ( 1056 / 7186 )
Lines 15.12% ( 4330 / 28624 )

@asteriscos asteriscos merged commit a5327b9 into 4.10.0 Nov 14, 2024
5 checks passed
@asteriscos asteriscos deleted the bug/7148-fix-endpoint-group-module-name-and-indexer-management-order branch November 14, 2024 18:13
@asteriscos asteriscos mentioned this pull request Nov 25, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@guidomodarelli guidomodarelli guidomodarelli approved these changes

Assignees

@chantal-kelm chantal-kelm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix endpoint group module name and indexer management order
4 participants
@chantal-kelm @guidomodarelli @yenienserrano @asteriscos