-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for CDB lists beginning with quotes #7171
Support for CDB lists beginning with quotes #7171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legend:
⚫ 🠊 The test hasn't started yet.
🟢 🠊 All checks passed.
🟡 🠊 There is at least one expected fail or skipped test and no failures.
🔴 🠊 There is at least one failed check.
⚪ 🠊 Doesn't apply.
🔧 🠊 Request changes.
CR 🔧
TEST ⚫
plugins/main/public/controllers/management/components/management/cdblists/views/list-editor.tsx
Outdated
Show resolved
Hide resolved
plugins/main/public/controllers/management/components/management/cdblists/views/list-editor.tsx
Outdated
Show resolved
Hide resolved
plugins/main/public/controllers/management/components/management/cdblists/views/list-editor.tsx
Outdated
Show resolved
Hide resolved
plugins/main/public/controllers/management/components/management/cdblists/views/list-editor.tsx
Outdated
Show resolved
Hide resolved
plugins/main/public/controllers/management/components/management/cdblists/views/list-editor.tsx
Outdated
Show resolved
Hide resolved
plugins/main/public/controllers/management/components/management/cdblists/views/list-editor.tsx
Outdated
Show resolved
Hide resolved
plugins/main/public/controllers/management/components/management/cdblists/views/list-editor.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plugins/main/public/controllers/management/components/management/cdblists/views/list-editor.tsx
Outdated
Show resolved
Hide resolved
plugins/main/public/controllers/management/components/management/cdblists/views/list-editor.tsx
Outdated
Show resolved
Hide resolved
plugins/main/public/controllers/management/components/management/cdblists/views/list-editor.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
32faa94
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Fixes the rendering of the table as in some cases they were not rendering correctly.
For example:
And added validations in the inputs.
Issues Resolved
Evidence
Test
key:
"key":key
"key:":"key:"
key1:"key:"
Check List
yarn test:jest