Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the command column in the Processes table #7195

Conversation

chantal-kelm
Copy link
Member

@chantal-kelm chantal-kelm commented Dec 5, 2024

Description

Expand command column, relocate argvs column and change the width of the rest of the columns in the table processes.

Issues Resolved

#7194

Evidence

image

Test

  • Verify that in the process table when the agent is linux, first the command column is shown at the end of the table and then argvs, and the table adapts well to different screen sizes.

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@chantal-kelm chantal-kelm self-assigned this Dec 5, 2024
@Tostti Tostti linked an issue Dec 9, 2024 that may be closed by this pull request
1 task
@chantal-kelm chantal-kelm marked this pull request as ready for review December 10, 2024 12:00
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 14.75% ( 4387 / 29725 )
Branches 9.74% ( 1878 / 19269 )
Functions 14.51% ( 1041 / 7174 )
Lines 14.96% ( 4280 / 28597 )

Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

image

@Desvelao
Copy link
Member

🟢 Test

image
image

Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asteriscos asteriscos merged commit accde5a into 4.10.1 Dec 11, 2024
5 of 6 checks passed
@asteriscos asteriscos deleted the enhancement/7194-expand-the-command-column-in-the-processes-table branch December 11, 2024 13:21
asteriscos added a commit that referenced this pull request Dec 11, 2024
* style(top_packages_table): increase padding size in EuiPanel for improved layout consistency and visual appearance

* style(vuls_welcome_panel): align text to the left for better readability in vulnerability panel component

* refactor(agents-welcome): update malware detection to vulnerability detection for better alignment with application terminology

* feat(ribbon): add condensed prop to IRibbonItem and implement logic for displaying condensed items in the ribbon component

* fix(dashboard_panels): adjust height of panel '1' from 12 to 7 for improved layout consistency in dashboard panels

* chore(changelog): document changes to agent details page for better readability and layout consistency

* fix(vuls_panel): change padding size of EuiPanel from 's' to 'm' for improved layout consistency in the welcome panel

* fix(agent_info): update IP address style to set min and max width for improved layout consistency in agent info display

* Add euiFlexGroup element to inventory test snapshot

* fix(agent_details): refine layout of agent details view for improved readability and consistency [#7193]

* feat(wz-text-tooltip): implement text truncation with tooltip for improved text display in component [#7194]

* style(ribbon-item): adjust max-width for mobile responsiveness in ribbon-item component [#7200]

* style(agent-info): update minWidth and maxWidth for better layout in agent info component [#7201]

* style(wz-text-tooltip): add anchorClassName for full width in tooltip component [#7195]

* feat(ribbon-item): enhance rendering logic and add render prop for dynamic content

* style(wz-ribbon-item): prevent growth of ribbon item for consistent layout [#7202]

* style(wz-ribbon-item): set font size and prevent growth for consistent layout across inventory components [#7206]

* style(agent-info): remove min-width for agent status to enhance layout consistency [#7207]

* style(agent-status): add custom margin for icon tip to improve alignment [#7208]

* style(agent-info): modify IP address styling to support IPv6 with adjusted min/max widths [#7209]

* style(ribbon): reduce group length in GroupTruncate to enhance display [#7210]

* style(agent-info): streamline styling by removing minWidth properties for cleaner display within agent info component [#7211]

* style(wz-text-tooltip): enhance text display responsiveness with word-break and white-space adjustments for smaller screens [#7212]

* Update lifecycle method from componentDidMount to componentDidUpdate

* Increase group truncate length to 30 characters

* style(agent-info): make 'Group' value condensed and remove maxWidth for 'Operating system' display

* fix(ribbon-item): rename elementStyle to contentStyle for clarity in WzTextWithTooltipIfTruncated component

* refactor(wz-text-tooltip): rename buildContent to renderContent for improved readability in WzTextWithTooltipIfTruncated component

* refactor(wz-text-tooltip): extract createClone method for cleaner code and improved readability in WzTextWithTooltipIfTruncated component

* refactor(ribbon-item): change item.style to contentStyle for improved clarity in WzRibbonItem component

* feat(platform): add getPlatformIcon and getOsName functions for improved agent OS representation in the application

* feat(agent-info): enhance OS display by integrating platform icon and name in InventoryMetrics and AgentInfo components

* refactor(ribbon-item): update WzTextWithTooltipIfTruncated to use contentStyle for cleaner code in ribbon-item component

* refactor(ribbon-item): use contentStyle instead of item.style for improved clarity in ribbon-item component rendering

* refactor(wz-text-with-tooltip): convert class to functional component with hooks for cleaner state management and rendering logic

* refactor(agent-info): add minWidth style to registration and last keep-alive fields for better layout consistency

* refactor(agent-status): update tooltip class name for improved styling consistency in status indicators

---------

Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand the command column in the Processes table
3 participants