Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shown Wazuh API version is wrong or empty after upgrade #7203

Merged
merged 21 commits into from
Dec 17, 2024
Merged

Shown Wazuh API version is wrong or empty after upgrade #7203

merged 21 commits into from
Dec 17, 2024
+367 −138

Conversation

guidomodarelli
Copy link
Contributor

@guidomodarelli guidomodarelli commented Dec 16, 2024 •
edited
Loading

Description

During wazuh/wazuh#27183, it was found that Wazuh API version shown is not the current one after upgrading from v4.9.2 to v4.10.0-rc1

image

After cleaning the cache, the error is worse

image

Expected behavior

Wazuh API is v4.10.0

image

Issues Resolved

Closes wazuh/wazuh-dashboard#440

Evidence

image

image

image

image

Test

  1. Navigate to Dashboard management » Server APIs
  2. Open DevTools
  3. Go to Application » Session storage
  4. Delete key checkUpdates
    image
  5. Reload the page
  6. Please verify the status of the Version column under two scenarios: when everything is correct and when an issue arises.

Note

Remove checkUpdates for each reloaded page.

Unit tests

image

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@guidomodarelli guidomodarelli linked an issue Dec 16, 2024 that may be closed by this pull request
Shown Wazuh API version is wrong or empty after upgrade wazuh/wazuh-dashboard#440
Closed
@guidomodarelli guidomodarelli self-assigned this Dec 16, 2024
@guidomodarelli
fix(get-updates): refactor update retrieval to include version handli…
33befd2 
…ng and optimize status checking logic for better clarity
@chantal-kelm chantal-kelm self-requested a review December 16, 2024 19:49
@guidomodarelli guidomodarelli requested a review from a team December 16, 2024 21:30
@Tostti Tostti self-requested a review December 17, 2024 11:25
Tostti
Tostti approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test 🟢

Tested in a pre-release environment, replacing the original plugins with new ones generated based on this branch
imagen

CR 🟢

LGTM

Tostti

This comment was marked as resolved.

Sign in to view

@JuanGarriuz
Copy link
Member

Test

image

@Desvelao
Copy link
Member

Desvelao commented Dec 17, 2024 •
edited
Loading

🟢 Test

image
image

@chantal-kelm found the Version column does not appear if wazuh.updates.disabled: true is enabled. I think the Version column should always appear. That value can be retrieved (as it is done in this pull request) from the Wazuh server API.

@guidomodarelli
fix(get-updates): update test cases to handle version formatting and …
b9740f1 
…improve mocking for Wazuh core interactions
@guidomodarelli
fix(get-updates): enhance tests by mocking last_available_patch for c…
c00c7fb 
…learer version handling and improved stability
@guidomodarelli
fix(get-updates): reorganize imports in test file for better readabil…
0b42585 
…ity and consistency with common constants and types
@guidomodarelli
fix(get-updates): refactor test setup to improve mocking of saved obj…
aa4c03f 
…ects and requests for more accurate updates handling
@guidomodarelli
fix(get-updates): standardize api_id and version formatting in tests …
de85db7 
…for consistent updates handling across all scenarios
@guidomodarelli
fix(get-updates): improve error handling and add tests for undefined …
66ff7a1 
…api_version scenarios in update fetching logic
@guidomodarelli
fix(get-updates): enhance error response handling and add test for du…
1654ad9 
…al request failure in update fetching logic
@guidomodarelli
fix(get-updates): remove unnecessary mock data from tests for clearer…
2e226f8 
… error handling in dual request failure scenarios
@guidomodarelli
fix(get-updates): add test for handling API errors on secondary reque…
de89706 
…st in update retrieval logic
@guidomodarelli
fix(get-updates): add test for retrieving updates when initial API ve…
d830303 
…rsion is undefined and secondary request fails
@guidomodarelli
fix(get-updates): refactor test cases to use 'it' for better consiste…
baaa0e5 
…ncy in update retrieval tests
@guidomodarelli
fix(get-updates): simplify test descriptions to improve readability i…
6b30220 
…n update retrieval tests
@guidomodarelli
fix(get-updates): enhance test descriptions for clarity in update ava…
568e801 
…ilability cases and error handling scenarios
@guidomodarelli guidomodarelli requested a review from a team December 17, 2024 15:15
Tostti
Tostti previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test 🟢
imagen

CR 🟢

LGTM

@guidomodarelli guidomodarelli requested a review from a team December 17, 2024 17:00
@guidomodarelli
fix(changelog): update entries for issue #7177 and add fix for incorr…
2019bce 
…ect Wazuh API version display after upgrade
@guidomodarelli
fix(changelog): correct rendering entry for vulnerability reference a…
3252cf3 
…nd clarify Wazuh API version display issue after upgrade
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 78.72% ( 185 / 235 )
Branches 62.72% ( 69 / 110 )
Functions 61.7% ( 29 / 47 )
Lines 78.72% ( 185 / 235 )

asteriscos
asteriscos approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

image

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 14.92% ( 4445 / 29774 )
Branches 9.77% ( 1877 / 19206 )
Functions 14.68% ( 1057 / 7200 )
Lines 15.14% ( 4339 / 28646 )

@asteriscos asteriscos merged commit acb171a into 4.10.0 Dec 17, 2024
5 checks passed
@asteriscos asteriscos deleted the bug/440-shown-wazuh-api-version-is-wrong-or-empty-after-upgrade branch December 17, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

@Tostti Tostti Tostti left review comments

@chantal-kelm chantal-kelm Awaiting requested review from chantal-kelm

Assignees

@guidomodarelli guidomodarelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shown Wazuh API version is wrong or empty after upgrade
5 participants
@guidomodarelli @JuanGarriuz @Desvelao @asteriscos @Tostti