Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default theme #174

Merged
merged 2 commits into from
May 10, 2024
Merged

Change default theme #174

merged 2 commits into from
May 10, 2024

Conversation

Tostti
Copy link
Member

@Tostti Tostti commented Apr 26, 2024

Description

This issue changes the default theme from Next to v7
Some tests needed to be disabled as they start to fail with these changes, and we don't have control over the test's repository.

Issues Resolved

#173

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Tostti Tostti self-assigned this Apr 26, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.39%. Comparing base (f066302) to head (b8b3df2).
Report is 84 commits behind head on 4.9.0.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##            4.9.0     #174       +/-   ##
===========================================
- Coverage   66.96%   55.39%   -11.58%     
===========================================
  Files        3300     1194     -2106     
  Lines       63585    24048    -39537     
  Branches    10141     4013     -6128     
===========================================
- Hits        42582    13321    -29261     
+ Misses      18538    10100     -8438     
+ Partials     2465      627     -1838     
Flag Coverage Δ
Linux_1 ?
Linux_2 55.39% <ø> (+0.22%) ⬆️
Linux_3 ?
Windows_1 ?
Windows_2 ?
Windows_3 ?
Windows_4 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tostti Tostti linked an issue May 2, 2024 that may be closed by this pull request
2 tasks
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Light mode

image image

Dark mode

image image

@Tostti Tostti merged commit c36dd6e into 4.9.0 May 10, 2024
62 checks passed
@Tostti Tostti deleted the 173-change-default-theme branch May 10, 2024 13:31
yenienserrano pushed a commit that referenced this pull request Jun 18, 2024
yenienserrano pushed a commit that referenced this pull request Jul 12, 2024
yenienserrano pushed a commit that referenced this pull request Aug 19, 2024
yenienserrano pushed a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the default theme in Wazuh Dashboard advanced settings
3 participants