Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change build number generation #284

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Conversation

Tostti
Copy link
Member

@Tostti Tostti commented Aug 29, 2024

Description

This PR replaces the build number generation method to adhere to the previous Wazuh standard

Issues Resolved

#283

Evidence

[root@localhost vagrant]# jq -r '.build.number' /usr/share/wazuh-dashboard/package.json
49006

image

Test

  • Build a new package following the steps in the documentation
  • Install Wazuh using the generated package and verify the build number in the package.json
  • In the browser dev-tools verify that the requests contains the build number

Tip

I generated a custom wazuh-install.zip for 4.9.0 that uses a local wazuh-dashboard.rpm to install the dashboard. The rpm package should be in the same directory as the script, that can be executed with bash wazuh-install.sh -a. This only works for OSs that uses RPM.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Tostti Tostti self-assigned this Aug 29, 2024
@Machi3mfl Machi3mfl self-requested a review August 29, 2024 13:25
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢

Test 🟢

Action execution in personal fork

image

package.json

{
  "name": "opensearch-dashboards",
  "description": "OpenSearch Dashboards is a browser based analytics and search dashboard for OpenSearch. OpenSearch Dashboards is a snap to setup and start using. OpenSearch Dashboards strives to be easy to get started with, while also being flexible and powerful, just like OpenSearch.",
  "keywords": [
    "opensearch-dashboards",
    "opensearch",
    "logstash",
    "analytics",
    "visualizations",
    "dashboards",
    "dashboarding"
  ],
  "version": "2.13.0",
  "branch": "2.x",
  "build": {
    "number": "49006",
    "sha": "a0c07e220c97dbab60477dced8c611efd495ad35",
    "distributable": true,
    "release": true
  },
  "wazuh": {
    "version": "4.9.0",
    "revision": "1"
  },
  "repository": {
    "type": "git",
    "url": "https://github.com/opensearch-project/opensearch-dashboards.git"
  },
  "engines": {
    "node": ">=14.20.1 <19"
  }
}

@asteriscos asteriscos merged commit 9d83c89 into 4.9.0 Aug 29, 2024
57 of 61 checks passed
@asteriscos asteriscos deleted the bug/283-fix-revision-number branch August 29, 2024 17:31
yenienserrano pushed a commit that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants