Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description and note for new parameters to generate_wazuh_msi.ps1 script to sign Windows packages #7501

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

jotacarma90
Copy link
Member

@jotacarma90 jotacarma90 commented Jul 4, 2024

Description

In this PR we want to add a brief description about the new parameters added in this wazuh/wazuh PR:

Its use is to give the possibility to the user to be able to indicate a specific certificate with his name and password, instead of the default option that selects the best match certificate of the Store.

Checks

Docs building

  • Compiles without warnings.

Code formatting and web optimization

  • Uses three spaces indentation.
  • Adds or updates meta descriptions accordingly.
  • Updates the redirects.js script if necessary (check this guide).

Writing style

  • Uses present tense, active voice, and semi-formal registry.
  • Uses short, simple sentences.
  • Uses bold for user interface elements, italics for key terms or emphasis, and code font for Bash commands, file names, REST paths, and code.

MarcelKemp
MarcelKemp previously approved these changes Jul 8, 2024
@javimed javimed added level/task Task issue type/enhancement Enhancement issue labels Jul 8, 2024
@javimed javimed merged commit 7988b5e into 4.10.0 Jul 11, 2024
3 checks passed
@javimed javimed deleted the enhancement/2826-add-cert-name-options-sign branch July 11, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/task Task issue type/enhancement Enhancement issue
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Windows Agent signing procedure only supports undocumented Certificate Store
3 participants