Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use maven for plugin download #139

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Conversation

f-galland
Copy link
Member

Description

This PR makes assemble.sh use mvn for retrieving the OpenSearch plugin artifacts instead of grabbing them directly using opensearch-plugin.
This allows the use mvn's local cache to avoid re-downloading plugins' zip files on each run, thus speeding testing.

Issues Resolved

Resolves #138

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • GitHub issue/PR created in OpenSearch documentation repo for the required public documentation changes (#[Issue/PR number])

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@f-galland f-galland changed the title Ci/138 use maven for plugin download Use maven for plugin download Jan 22, 2024
@f-galland f-galland marked this pull request as ready for review January 22, 2024 14:51
@f-galland f-galland requested a review from a team as a code owner January 22, 2024 14:51
@AlexRuiz7 AlexRuiz7 merged commit 52baf4e into 4.9.0 Jan 22, 2024
15 checks passed
@AlexRuiz7 AlexRuiz7 deleted the ci/138-use-maven-for-plugin-download branch January 22, 2024 15:19
AlexRuiz7 added a commit that referenced this pull request Mar 8, 2024
* Fine tuning permissions on RPM spec file

* Get plugins using maven

* Rolling back changes to spec file

* Format files

---------

Co-authored-by: Álex Ruiz <alejandro.ruiz.becerra@wazuh.com>
AlexRuiz7 added a commit that referenced this pull request Apr 24, 2024
* Fine tuning permissions on RPM spec file

* Get plugins using maven

* Rolling back changes to spec file

* Format files

---------

Co-authored-by: Álex Ruiz <alejandro.ruiz.becerra@wazuh.com>
AlexRuiz7 added a commit that referenced this pull request Jun 28, 2024
* Fine tuning permissions on RPM spec file

* Get plugins using maven

* Rolling back changes to spec file

* Format files

---------

Co-authored-by: Álex Ruiz <alejandro.ruiz.becerra@wazuh.com>
AlexRuiz7 added a commit that referenced this pull request Aug 20, 2024
* Fine tuning permissions on RPM spec file

* Get plugins using maven

* Rolling back changes to spec file

* Format files

---------

Co-authored-by: Álex Ruiz <alejandro.ruiz.becerra@wazuh.com>
AlexRuiz7 added a commit that referenced this pull request Sep 9, 2024
* Fine tuning permissions on RPM spec file

* Get plugins using maven

* Rolling back changes to spec file

* Format files

---------

Co-authored-by: Álex Ruiz <alejandro.ruiz.becerra@wazuh.com>
AlexRuiz7 added a commit that referenced this pull request Sep 9, 2024
* Fine tuning permissions on RPM spec file

* Get plugins using maven

* Rolling back changes to spec file

* Format files

---------

Co-authored-by: Álex Ruiz <alejandro.ruiz.becerra@wazuh.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize plugins installation during packages' assembly
2 participants