Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added release number to dashboard app package #1630

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

okynos
Copy link
Contributor

@okynos okynos commented Jun 7, 2022

Related issue
https://github.com/wazuh/wazuh-jenkins/issues/3551

Description

Hello!

We have included a little changes to allow Wazuh dashboard app package to build as any other package

Tests

  • Build the package in any supported platform
    • Linux

@okynos okynos requested review from alberpilot and rauldpm June 7, 2022 14:32
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

./artifacts_generated/builder.sh:12:10:warning:Declare and assign separately to avoid masking return values.
./artifacts_generated/builder.sh:18:10:warning:resources_download appears unused. Verify use (or export if used externally).
./artifacts_generated/builder.sh:69:9:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:73:14:info:Expressions don't expand in single quotes, use double quotes for that.
./artifacts_generated/builder.sh:77:9:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:80:14:info:Expressions don't expand in single quotes, use double quotes for that.
./artifacts_generated/builder.sh:84:5:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:85:25:info:Double quote to prevent globbing and word splitting.
./artifacts_generated/builder.sh:89:26:warning:Prefer mapfile or read -a to split command output (or quote to avoid splitting).
./artifacts_generated/builder.sh:90:23:warning:Prefer mapfile or read -a to split command output (or quote to avoid splitting).
./artifacts_generated/builder.sh:90:37:error:Double quote array expansions to avoid re-splitting elements.
./artifacts_generated/builder.sh:90:37:error:Argument mixes string and array. Use * or separate argument.
./artifacts_generated/builder.sh:90:37:warning:The surrounding quotes actually unquote this. Remove or escape them.
./artifacts_generated/builder.sh:90:37:warning:eval negates the benefit of arrays. Drop eval to preserve whitespace/symbols (or eval as string).
./artifacts_generated/builder.sh:92:62:style:Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
./artifacts_generated/builder.sh:103:22:warning:Prefer mapfile or read -a to split command output (or quote to avoid splitting).
./artifacts_generated/builder.sh:104:28:warning:Prefer mapfile or read -a to split command output (or quote to avoid splitting).
./artifacts_generated/builder.sh:107:13:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:108:54:info:Double quote to prevent globbing and word splitting.
./artifacts_generated/builder.sh:114:5:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:140:5:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:155:24:warning:Prefer mapfile or read -a to split command output (or quote to avoid splitting).
./artifacts_generated/builder.sh:156:30:warning:Prefer mapfile or read -a to split command output (or quote to avoid splitting).
./artifacts_generated/builder.sh:156:44:error:Double quote array expansions to avoid re-splitting elements.
./artifacts_generated/builder.sh:156:44:error:Argument mixes string and array. Use * or separate argument.
./artifacts_generated/builder.sh:156:44:warning:The surrounding quotes actually unquote this. Remove or escape them.
./artifacts_generated/builder.sh:156:44:warning:eval negates the benefit of arrays. Drop eval to preserve whitespace/symbols (or eval as string).
./artifacts_generated/builder.sh:159:13:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:166:5:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:180:5:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:195:20:warning:Prefer mapfile or read -a to split command output (or quote to avoid splitting).
./artifacts_generated/builder.sh:196:26:warning:Prefer mapfile or read -a to split command output (or quote to avoid splitting).
./artifacts_generated/builder.sh:196:40:error:Double quote array expansions to avoid re-splitting elements.
./artifacts_generated/builder.sh:196:40:error:Argument mixes string and array. Use * or separate argument.
./artifacts_generated/builder.sh:196:40:warning:The surrounding quotes actually unquote this. Remove or escape them.
./artifacts_generated/builder.sh:196:40:warning:eval negates the benefit of arrays. Drop eval to preserve whitespace/symbols (or eval as string).
./artifacts_generated/builder.sh:199:13:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:206:5:style:Consider using { cmd1; cmd2; } >> file instead of individual redirects.
./artifacts_generated/builder.sh:248:19:info:Double quote to prevent globbing and word splitting.
./artifacts_generated/builder.sh:253:19:info:Double quote to prevent globbing and word splitting.
./artifacts_generated/builder.sh:258:19:info:Double quote to prevent globbing and word splitting.

@alberpilot alberpilot merged commit 9b4487b into 4.3 Jun 7, 2022
@alberpilot alberpilot deleted the wj3551-release-dashboard-app branch June 7, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants