-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Wazuh dashboard build_number is updated with the Wazuh app parameters to 4.4 #2054
The Wazuh dashboard build_number is updated with the Wazuh app parameters to 4.4 #2054
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should specify some type of control over the URL that is specified, it may be the case that a URL like the following is specified:
https://packages-dev-fail.wazuh.com/pre-release/ui/dashboard/wazuh-1-1.zip
This URL will be accepted and will be used to download and install the Wazuh app during the construction of the package, which would end up failing, which could be avoided by checking the code that returns a curl beforehand.
If the URL is not valid, it should show a message and end the execution with an error status instead of using a default Wazuh URL.
The functionality is added in this commit: 69b748b It was used to add a new parameter in the deb and rpm build_package.sh scripts to decide if you want to build a new base or use an existing one, this is quite useful to save time when you are developing locally Tests: ./build_package.sh -s /tmp -b no --app-url "https://packages-dev.wazuh.com/trash/ui/dashboard/wazuh-4.4.0-1.1.1.todelete.zip" ./build_package.sh -s /tmp -b no --app-url "https://packages-dev.wazuh.com/trash/ui/dashboard/wazuh-4.4.0-.todelete.zip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ters to 4.4 (#2054) * Added feature to obtain build_number from Wazuh plugin zip * Removed full path for packages.json tmp file * Added quotes to var * Added validation for plugin URL * Added indentation Signed-off-by: jnasselle <jnasselle@gmail.com>
…ters to 4.4 (#2054) * Added feature to obtain build_number from Wazuh plugin zip * Removed full path for packages.json tmp file * Added quotes to var * Added validation for plugin URL * Added indentation Signed-off-by: jnasselle <jnasselle@gmail.com>
Description
A modification is made in the construction of the base so that the Wazuh dashboard package has the corresponding build_number included in its packages.json according to the Wazuh plugin that is installed in the package itself
Logs example
4.3.0:
4.4.0:
Tests
Centos 7: https://devel.ci.wazuh.info/view/Tests/job/Test_stack/412/console
Ubuntu Focal: https://devel.ci.wazuh.info/view/Tests/job/Test_stack/413/console
%files
section is correctly updated if necessary%files
section is correctly updated if necessary