Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not remove packages_files directory #2087

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Do not remove packages_files directory #2087

merged 1 commit into from
Feb 9, 2023

Conversation

DFolchA
Copy link
Contributor

@DFolchA DFolchA commented Feb 9, 2023

Related issue
#2081

Description

This PR fixes the database error caused by removing the packages_files directory in the post-install script of the Alpine Linux packages.

Logs example

/packages # apk add --allow-untrusted wazuh-agent-4.4.0-r1.apk
fetch https://dl-cdn.alpinelinux.org/alpine/v3.16/main/x86_64/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/v3.16/community/x86_64/APKINDEX.tar.gz
(1/8) Installing libintl (0.21-r2)
(2/8) Installing ncurses-terminfo-base (6.3_p20220521-r0)
(3/8) Installing ncurses-libs (6.3_p20220521-r0)
(4/8) Installing libproc (3.3.17-r1)
(5/8) Installing procps (3.3.17-r1)
(6/8) Installing libgcc (11.2.1_git20220219-r2)
(7/8) Installing libstdc++ (11.2.1_git20220219-r2)
(8/8) Installing wazuh-agent (4.4.0-r1)
Executing wazuh-agent-4.4.0-r1.pre-install
Executing wazuh-agent-4.4.0-r1.post-install
Executing busybox-1.35.0-r17.trigger
OK: 25 MiB in 22 packages

Tests

  • Build the package in any supported platform
    • Alpine
  • Package installation
  • Package upgrade
  • Package downgrade
  • Package remove
  • Package install/remove/install
  • Change added to CHANGELOG.md

@DFolchA DFolchA requested a review from alberpilot February 9, 2023 17:09
@DFolchA DFolchA self-assigned this Feb 9, 2023
@DFolchA DFolchA linked an issue Feb 9, 2023 that may be closed by this pull request
Alpine package error during installation #2081
Closed
@alberpilot alberpilot merged commit 8b94f1c into 4.4 Feb 9, 2023
@alberpilot alberpilot deleted the 2081-alpine-package-error-during-installation branch February 9, 2023 17:11
alberpilot pushed a commit that referenced this pull request Feb 16, 2023
@DFolchA
Update solaris10 pkginfo 4.4.0 (#2101)
daeeaa5 
* Do not remove packages_files directory (#2087)

* Update version in pkginfo Solaris 10
DFolchA added a commit that referenced this pull request Mar 2, 2023
@DFolchA
Do not remove packages_files directory (#2087)
a0bed47
jnasselle pushed a commit that referenced this pull request Apr 11, 2023
@DFolchA @jnasselle
Update solaris10 pkginfo 4.4.0 (#2101)
3682797 
* Do not remove packages_files directory (#2087)

* Update version in pkginfo Solaris 10

Signed-off-by: jnasselle <jnasselle@gmail.com>
jnasselle pushed a commit that referenced this pull request Apr 11, 2023
@DFolchA @jnasselle
Do not remove packages_files directory (#2087)
979b407 
Signed-off-by: jnasselle <jnasselle@gmail.com>
jnasselle pushed a commit that referenced this pull request Apr 11, 2023
@DFolchA @jnasselle
Do not remove packages_files directory (#2087)
0c7dc8d 
Signed-off-by: jnasselle <jnasselle@gmail.com>
jnasselle pushed a commit that referenced this pull request Apr 11, 2023
@DFolchA @jnasselle
Update solaris10 pkginfo 4.4.0 (#2101)
da422bb 
* Do not remove packages_files directory (#2087)

* Update version in pkginfo Solaris 10

Signed-off-by: jnasselle <jnasselle@gmail.com>
jnasselle pushed a commit that referenced this pull request Apr 11, 2023
@DFolchA @jnasselle
Do not remove packages_files directory (#2087)
eb87a06 
Signed-off-by: jnasselle <jnasselle@gmail.com>
jnasselle pushed a commit that referenced this pull request Apr 11, 2023
@DFolchA @jnasselle
Do not remove packages_files directory (#2087)
e4803d5 
Signed-off-by: jnasselle <jnasselle@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okynos okynos okynos approved these changes

@alberpilot alberpilot alberpilot approved these changes

Assignees

@DFolchA DFolchA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alpine package error during installation
3 participants
@DFolchA @alberpilot @okynos