Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify the side menu and remove the mlCommonsDashboards plugin on Wazuh dashboard #2540

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Modify the side menu and remove the mlCommonsDashboards plugin on Wazuh dashboard #2540

merged 4 commits into from
Oct 23, 2023

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Oct 20, 2023 •
edited
Loading

Related issue
wazuh/wazuh-dashboard-plugins#5893

Description

This pull request modifies the categories and application categories on the side menu of the Wazuh dashboard.

Changes:

  • Replace the link to the home app from /app/wazuh to /app/wz-home
  • Add Explore category
  • Rename the Dashboards management category to Indexer/dashboard Management
  • Change to Explore category the following applications:
    • Discover
    • Dashboards
    • Visualize
    • Reporting
    • Alerting
    • Maps
    • Notifications
  • Change category to Indexer/dashboard Management:
    • Index Management
    • Snapshot management
    • Security
  • Change the order of the following applications:
    • Discover
    • Dashboards
    • Visualize
    • Dev tools
    • Dashboards management
    • Security
    • Index management
    • Snapshot management
  • Avoid the Overview application of the Management category is registered
  • Avoid the Overview application of the Management category is registered to the feature catalog
  • Remove the mlCommonsDashboards plugin

Logs example

Tests

  • Build the package in any supported platform
    • Linux
    • Windows
    • macOS
    • Solaris
    • AIX
    • HP-UX
  • Package installation
  • Package upgrade
  • Package downgrade
  • Package remove
  • Package install/remove/install
  • Change added to CHANGELOG.md
  • Tests for Linux RPM
    • Build the package for x86_64
    • Build the package for i386
    • Build the package for armhf
    • Build the package for aarch64
    • %files section is correctly updated if necessary
  • Tests for Linux deb
    • Build the package for x86_64
    • Build the package for i386
    • Build the package for armhf
    • Build the package for aarch64
    • Package install/remove/install
    • Package install/purge/install
    • Check file permissions after installing the package
  • Tests for macOS
    • Test the package from macOS Sierra to Mojave
  • Tests for Solaris
    • Test the package on Solaris 10
    • Test the package on Solaris 11
    • Check file permissions on Solaris 11 template
  • Tests for IBM AIX
    • %files section is correctly updated if necessary
    • Check the changes from IBM AIX 5 to 7

@Desvelao
feat(wazuh-dashboard): replace default application to /app/wz-home (#…
8b72fe6 
…2497)
@Desvelao
Change the category of built-in applications on Wazuh dashboard (#2496)
c01be01 
* feat(wazuh-dashboard): Change the category of built-in applications

* feat(wazuh-dashboard): change order value to Explore app category

* feat(wazuh-dashboard): change name to Management category

* feat: replace order for built-in applications

* feat(dashboard): replace icon for Explore app category

* fix(dahsboard): icon for Explore app category

* feat(dashboard): avoid the registration of Overview application of Management category and minor fixes

* fix(dashbord): comment
@Desvelao Desvelao self-assigned this Oct 20, 2023
@Desvelao Desvelao linked an issue Oct 20, 2023 that may be closed by this pull request
Update the new sidebar menu design wazuh/wazuh-dashboard-plugins#5893
Closed
4 tasks
@Desvelao Desvelao changed the title Modify the categories and app categories on the side menu of Wazuh dashboard Modify the side menu and remove the mlCommonsDashboards plugin on Wazuh dashboard Oct 20, 2023
@rauldpm rauldpm mentioned this pull request Oct 20, 2023
Closed
13 tasks
rauldpm
rauldpm requested changes Oct 23, 2023
View reviewed changes
stack/dashboard/base/builder.sh Show resolved Hide resolved
stack/dashboard/base/builder.sh Show resolved Hide resolved
@rauldpm rauldpm self-requested a review October 23, 2023 12:25
@yenienserrano
Copy link
Member

yenienserrano commented Oct 23, 2023 •
edited
Loading

LGTM

🟢 With Wazuh

image
image
image

🟢 Without Wazuh

image

yenienserrano
yenienserrano approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Desvelao Desvelao merged commit bf159b3 into enhancement/2521-bump-dashboard Oct 23, 2023
@Desvelao Desvelao deleted the enhancement/wd-83-global-menu branch October 23, 2023 15:05
damarisg pushed a commit that referenced this pull request Nov 2, 2023
@Desvelao @damarisg
Modify the side menu and remove the mlCommonsDashboards plugin on Waz…
c85e0f0 
…uh dashboard (#2540)

* feat(wazuh-dashboard): replace default application to /app/wz-home (#2497)

* Change the category of built-in applications on Wazuh dashboard (#2496)

* feat(wazuh-dashboard): Change the category of built-in applications

* feat(wazuh-dashboard): change order value to Explore app category

* feat(wazuh-dashboard): change name to Management category

* feat: replace order for built-in applications

* feat(dashboard): replace icon for Explore app category

* fix(dahsboard): icon for Explore app category

* feat(dashboard): avoid the registration of Overview application of Management category and minor fixes

* fix(dashbord): comment

* fix: remove comment

* feat(dashboard): remove mlCommonsDashboards plugin
@yenienserrano yenienserrano mentioned this pull request Feb 5, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@rauldpm rauldpm rauldpm approved these changes

Assignees

@Desvelao Desvelao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the new sidebar menu design
3 participants
@Desvelao @yenienserrano @rauldpm