Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix home button navigation on click #2556

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Fix home button navigation on click #2556

merged 1 commit into from
Oct 25, 2023

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Oct 25, 2023 •
edited
Loading

Related issue
wazuh/wazuh-dashboard-plugins#5893

Description

This pull request fixes the navigation of home button to the home application (wz-home).

Logs example

Tests

  • Build the package in any supported platform
    • Linux
    • Windows
    • macOS
    • Solaris
    • AIX
    • HP-UX
  • Package installation
  • Package upgrade
  • Package downgrade
  • Package remove
  • Package install/remove/install
  • Change added to CHANGELOG.md
  • Tests for Linux RPM
    • Build the package for x86_64
    • Build the package for i386
    • Build the package for armhf
    • Build the package for aarch64
    • %files section is correctly updated if necessary
  • Tests for Linux deb
    • Build the package for x86_64
    • Build the package for i386
    • Build the package for armhf
    • Build the package for aarch64
    • Package install/remove/install
    • Package install/purge/install
    • Check file permissions after installing the package
  • Tests for macOS
    • Test the package from macOS Sierra to Mojave
  • Tests for Solaris
    • Test the package on Solaris 10
    • Test the package on Solaris 11
    • Check file permissions on Solaris 11 template
  • Tests for IBM AIX
    • %files section is correctly updated if necessary
    • Check the changes from IBM AIX 5 to 7

@Desvelao Desvelao self-assigned this Oct 25, 2023
@Desvelao Desvelao linked an issue Oct 25, 2023 that may be closed by this pull request
Change the default app wazuh/wazuh-dashboard#92
Closed
2 tasks
yenienserrano
yenienserrano approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

@Desvelao Desvelao merged commit 42bea02 into enhancement/2521-bump-dashboard Oct 25, 2023
@Desvelao Desvelao deleted the fix/wd-83-global-menu-replace-navigation-home-button branch October 25, 2023 14:50
damarisg pushed a commit that referenced this pull request Nov 2, 2023
@Desvelao @damarisg
fix: header button navigation to home application (wz-home) (#2556)
340b9c9
@yenienserrano yenienserrano mentioned this pull request Feb 5, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@rauldpm rauldpm rauldpm approved these changes

Assignees

@Desvelao Desvelao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the default app
3 participants
@Desvelao @rauldpm @yenienserrano