Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kitchen testing for Wazuh deployment with Puppet #139

Merged
merged 29 commits into from
Aug 7, 2019

Conversation

rshad
Copy link
Contributor

@rshad rshad commented Jul 30, 2019

Hi all!

This PR implementes the changes requested in the issue #124.

In this PR we implemented Kitchen testing for Wazuh deployment with Puppet, implementing tests for wazuh-manager and wazuh-agent installation and agent registration, on different distribuitions such as Ubuntu and CentOS.

Kr,

Rshad

@@ -216,7 +216,7 @@
}else{
fail('This ossec module has not been tested on your distribution')
}
}'Debian', 'debian':{
}'Debian', 'debian', 'Ubuntu', 'ubuntu':{
Copy link
Contributor

@jm404 jm404 Jul 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this changes that affect agent.pp should be implemented in another issue in order to have better tracking of it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jose!

Thank you for reviewing!

Here I created a new issue related to such change: #140

Kr,

Rshad

@@ -294,7 +294,7 @@
}else{
fail('This ossec module has not been tested on your distribution')
}
}'Debian', 'debian':{
}'Debian', 'debian', 'Ubuntu', 'ubuntu':{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this change should be on another issue and its corresponding PR for tracking purposes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jose!

Thank you for reviewing!

Here I created a new issue related to such change: #140

Kr,

Rshad

Copy link
Contributor

@jm404 jm404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rshad,

I suggested some changes, please have a look at them!

@manuasir manuasir self-requested a review July 31, 2019 11:27
@manuasir manuasir changed the base branch from 3.9.3_7.2.0 to 3.9.4_7.2.0 August 7, 2019 10:30
@manuasir manuasir merged commit e2f134e into 3.9.4_7.2.0 Aug 7, 2019
@manuasir manuasir deleted the 3.9.3_7.2.0_kitchen_tests branch August 7, 2019 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants