Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement - Scan Tests - Include commit support for code analysis scan tests #3134

Closed
Rebits opened this issue Jul 27, 2022 · 0 comments · Fixed by #3135
Closed

Enhancement - Scan Tests - Include commit support for code analysis scan tests #3134

Rebits opened this issue Jul 27, 2022 · 0 comments · Fixed by #3135

Comments

@Rebits
Copy link
Member

Rebits commented Jul 27, 2022

Description

Regarding the effort to integrate scan tests into the integration process, it is required to adapt the clone_wazuh_repository fixture, to allow users a commit attribute.

Current behavior

The test_python_flaws receives the branch and the repository to scan. Due to the CI process using commits SHA instead, it is required to add a commit attribute.

Expected behavior

Scan module will accept a commit attribute. This will be None by default. In this case, will use branch value.
In case of setting a committed value, it will search the first branch that contains that commit, making the repository checkout that reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants