-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cluster performance test #2130
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Selutario
force-pushed
the
1939-cluster-performance-test
branch
from
October 27, 2021 08:10
54ee28b
to
71cc270
Compare
AdriiiPRodri
previously approved these changes
Nov 2, 2021
Selutario
changed the base branch from
feature/1938-cluster-stas-script
to
master
November 2, 2021 11:27
Merged
davidjiglesias
approved these changes
Nov 4, 2021
snaow
reviewed
Nov 30, 2021
tests/performance/test_cluster/test_cluster_performance/test_cluster_performance.py
Show resolved
Hide resolved
snaow
approved these changes
Nov 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get_datetime_diff should be part of common Framework functions and no local test function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS PR SHOULD BE MERGED TO MASTER AFTER #2032 IS MERGED
Description
This PR adds a new test that checks if cluster behavior is correct. It generates some stats from data in CSVs with information of a cluster environment and then, each stat is compared against a threshold that is defined in advance (inside the
data
folder).The thresholds are provisional and small changes are likely to be made in the future.
Configuration options
The test currently contains two configurations:
It is possible to add new configurations in the future. In addition, the test requires 3 parameters to correctly work, as well as other optional ones to generate HTML reports:
--n_workers
: Number of workers node in the cluster environment.--n_agents
: Number of agents in the cluster environment.--artifacts_path
: Path where CSVs with cluster information can be found. It should follow the structure below:--html=report.html
: Create a html report with the test results.--self-contained-html
: Store all the necessary data for the report inside the html file.Logs example
The test creates a report where each exceeded threshold is inserted inside a table (red arrow). It also shows the duration of each phase (green arrow):