Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Remoted IT: test_agent_communication #3088

Merged
merged 3 commits into from
Jul 13, 2022
Merged

Fix Remoted IT: test_agent_communication #3088

merged 3 commits into from
Jul 13, 2022

Conversation

juliamagan
Copy link
Member

@juliamagan juliamagan commented Jul 11, 2022 •
edited by jmv74211
Loading

Related issue
Closes: #3087

Description

After the review made in #3060, we have seen that two tests of test_agent_communication were failing consistently:

  • test_shared_configuration.py
  • test_agent_version_shared_configuration_startup_message.py

The error was that the keep-alives were not being sent correctly.

Updated

  • Update check_push_shared_config in wazuh_testing/remote.py

Testing performed

Package

Component Link
Manager https://packages-dev.wazuh.com/warehouse/pullrequests/4.3/rpm/var/wazuh-manager-4.3.6-0.commit2c426d5.x86_64.rpm
Tester Test path Jenkins Local OS Commit Notes
@juliamagan (Developer) test_remoted/ 🟢🟢🟢 🟢🟢🟢 CentOS 9988190 Nothing to highlight
@jmv74211 (Reviewer) 🟢🟢🟢 🚫 🚫 🚫 Nothing to highlight

@juliamagan juliamagan requested a review from jmv74211 July 11, 2022 15:55
@juliamagan juliamagan self-assigned this Jul 11, 2022
@juliamagan juliamagan mentioned this pull request Jul 11, 2022
Closed
4 tasks
@juliamagan juliamagan linked an issue Jul 11, 2022 that may be closed by this pull request
Fix Remoted IT: test_agent_communication #3087
Closed
@jmv74211 jmv74211 merged commit f4b0f68 into 4.3 Jul 13, 2022
@jmv74211 jmv74211 deleted the 3087-fix-agent-communication branch July 13, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmv74211 jmv74211 jmv74211 approved these changes

Assignees

@juliamagan juliamagan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Remoted IT: test_agent_communication
2 participants
@juliamagan @jmv74211