-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Integratord tests #3362
Fix Integratord tests #3362
Conversation
After a change made in a message, we had to change a callback from ERROR to WARNING. Also, we have to change the test cases IDs for us to be capable of running tests selecting them by theirs IDs. Finally, we made changes to the current documentation. Refs: wazuh/wazuh#14431
tests/integration/test_integratord/data/test_cases/cases_integratord_change_inode_alert.yaml
Outdated
Show resolved
Hide resolved
tests/integration/test_integratord/test_integratord_change_inode_alert.py
Outdated
Show resolved
Hide resolved
# Read Response in ossec.log | ||
check_integratord_event(file_monitor=wazuh_monitor, timeout=global_parameters.default_timeout, | ||
check_integratord_event(file_monitor=wazuh_monitor, timeout=global_parameters.default_timeout + 2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you add +2
hardcoded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@damarisg Because after multiple executions that was the time in which Wazuh managed to process the alert and display the expected message in the log.
Detect when analysisd has finished its initialization. Set analysisd in debug mode to detect its initialization. Restart fixture changed to restart a list of daemons and stop them in order.
Update 27/09/2022The tests are failing: 🔴 After modifying the test so that only the necessary daemons are restarted, the test started to run faster. This message appeared in the
I see 2 possible solutions:
Update: The second alternative will be applied. |
Some timeouts were replaced with the default timeout. Somo minor changes in the test documentation were applied.
Duplicated #3499 |
Description
After a change was made in a message, we had to change a callback from ERROR to WARNING.
Also, we have to change the test case IDs to be capable of running tests and selecting them by their IDs.
Finally, we made changes to the current documentation.
Refs: wazuh/wazuh#14431
Updated
test_integratord_change_json_inode
: The sleep time was reduced to 1 second becausewazuh-integratord
has a one-second delaydeps/wazuh_testing/wazuh_testing/modules/integratord/__init__.py
: A callback was changed.Testing performed
test_integratord_change_inode_alert.py
is unstable, and it cause is being researched