-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor test only future events #3484
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebits
approved these changes
Oct 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jmv74211
suggested changes
Oct 19, 2022
deps/wazuh_testing/wazuh_testing/modules/logcollector/event_monitor.py
Outdated
Show resolved
Hide resolved
tests/integration/test_logcollector/test_only_future_events/test_only_future_events.py
Outdated
Show resolved
Hide resolved
tests/integration/test_logcollector/test_only_future_events/test_only_future_events.py
Show resolved
Hide resolved
tests/integration/test_logcollector/test_only_future_events/test_only_future_events.py
Outdated
Show resolved
Hide resolved
tests/integration/test_logcollector/test_only_future_events/test_only_future_events.py
Outdated
Show resolved
Hide resolved
jmv74211
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix the
test_only_future_events
reported as unstable.A full refactor of the test with the new QA structure has been carried on.
Added
The following files have been added to the
test_only_future_events
configuration_only_future_events.yaml
cases_only_future_events.yaml
Testing performed
Here are the links to the Jenkins execution: