Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_assign_agent_group_with_enrollment #3956

Merged
merged 5 commits into from
Mar 17, 2023

Conversation

juliamagan
Copy link
Member

@juliamagan juliamagan commented Feb 16, 2023

Related issue
#3862

Description

It has been decided that the test will not check if the default group is assigned in the worker before it receives information from the master. However, when applying this change, a race condition was seen where, when assigning a group with enrollment, the client.keys and the groups are synchronized at the same time, so it fails to insert the groups into the database. It has been decided that the test will wait for the Agent-groups send full task to run and then check that the assigned group is as expected.

Deleted

  • Deleted check of default group in test_assign_agent_group_with_enrollment

Testing performed

Tester Test path Jenkins Local Commit Notes
@juliamagan (Developer) test_cluster/test_agent_groups/test_assign_agent_group_with_enrollment.py 🚫 🚫 🚫 🟢 🟢 🟢 6bb6279 Nothing to highlight
@user (Reviewer) 🚫 🚫 🚫 🚫 🚫 🚫 Nothing to highlight

@juliamagan juliamagan self-assigned this Feb 16, 2023
@juliamagan juliamagan linked an issue Feb 16, 2023 that may be closed by this pull request
@juliamagan juliamagan requested a review from jmv74211 March 17, 2023 11:20
@jmv74211 jmv74211 merged commit e84230a into 4.4 Mar 17, 2023
@jmv74211 jmv74211 deleted the 3862-test-assign-group-enrollment-fix branch March 17, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix test_assign_agent_group_with_enrollment
2 participants