Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boto3 version requirement for legacy OS #4150

Merged
merged 1 commit into from
May 16, 2023

Conversation

jnasselle
Copy link
Member

@jnasselle jnasselle commented May 5, 2023

Related issue
#4152

Description

Since Wazuh 4.5 and the Add AWS integration tests #3333 implementation, boto3 python dependencies were added requesting a specific version that is not available on older/legacy OS

This PR aims to pair, at least, the requested version with the one integrated with the Wazuh Manager embedded Python interpreter

Added

  • None

Updated

Deleted

  • None

Testing performed

Tester Test path Jenkins Local OS Commit Notes
@jnasselle (Developer) ⚫⚫⚫ ⚫⚫⚫ Nothing to highlight
@user (Reviewer) ⚫⚫⚫ 🚫 🚫 🚫 Nothing to highlight

@jnasselle jnasselle self-assigned this May 5, 2023
@jnasselle jnasselle force-pushed the 4.5-fix-qa-boto3-requirement branch from 5ec5e12 to 90bd53f Compare May 8, 2023 18:24
@jnasselle jnasselle marked this pull request as ready for review May 8, 2023 18:25
@jnasselle jnasselle linked an issue May 8, 2023 that may be closed by this pull request
@jnasselle
Copy link
Member Author

Update

On hold because IT cannot be tested due

@jnasselle jnasselle force-pushed the 4.5-fix-qa-boto3-requirement branch from 790f372 to 04d5621 Compare May 9, 2023 13:03
Copy link
Member

@nico-stefani nico-stefani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the tests with

root@ip-172-31-82-0:/home/ubuntu/wazuh-qa/tests/integration/test_aws# pip freeze | grep boto
boto3==1.17.85
botocore==1.20.112

And these are the results

root@ip-172-31-82-0:/home/ubuntu/wazuh-qa/tests/integration/test_aws# pytest --disable-warnings --tb=line --tier 1 -x
================================================================================================ test session starts ================================================================================================
platform linux -- Python 3.10.6, pytest-7.1.2, pluggy-1.0.0
rootdir: /home/ubuntu/wazuh-qa/tests/integration, configfile: pytest.ini
plugins: metadata-2.0.4, html-3.1.1, testinfra-5.0.0
collected 195 items / 179 deselected / 16 selected

test_only_logs_after.py ..............x.                                                                                                                                                                      [100%]

======================================================================= 15 passed, 179 deselected, 1 xfailed, 6 warnings in 362.85s (0:06:02) =======================================================================
root@ip-172-31-82-0:/home/ubuntu/wazuh-qa/tests/integration/test_aws# pytest --disable-warnings --tb=line --tier 0 -x
================================================================================================ test session starts ================================================================================================
platform linux -- Python 3.10.6, pytest-7.1.2, pluggy-1.0.0
rootdir: /home/ubuntu/wazuh-qa/tests/integration, configfile: pytest.ini
plugins: metadata-2.0.4, html-3.1.1, testinfra-5.0.0
collected 195 items / 16 deselected / 179 selected

test_basic.py ................                                                                                                                                                                                [  8%]
test_discard_regex.py ..............                                                                                                                                                                          [ 16%]
test_log_groups.py ..                                                                                                                                                                                         [ 17%]
test_only_logs_after.py ...............................                                                                                                                                                       [ 35%]
test_parser.py ..........................                                                                                                                                                                     [ 49%]
test_path.py ..........................................                                                                                                                                                       [ 73%]
test_path_suffix.py .........                                                                                                                                                                                 [ 78%]
test_regions.py ........................                                                                                                                                                                      [ 91%]
test_remove_from_bucket.py ...sss.........                                                                                                                                                                    [100%]

====================================================================== 176 passed, 3 skipped, 16 deselected, 6 warnings in 3604.59s (1:00:04) =======================================================================

@jnasselle jnasselle force-pushed the 4.5-fix-qa-boto3-requirement branch from 04d5621 to c24e533 Compare May 11, 2023 11:46
@damarisg damarisg merged commit 4d2f9c3 into 4.5 May 16, 2023
@damarisg damarisg deleted the 4.5-fix-qa-boto3-requirement branch May 16, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service tests are failing due boto3 requirement
3 participants