-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix boto3 version requirement for legacy OS #4150
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnasselle
force-pushed
the
4.5-fix-qa-boto3-requirement
branch
from
May 8, 2023 18:24
5ec5e12
to
90bd53f
Compare
UpdateOn hold because IT cannot be tested due
|
jnasselle
force-pushed
the
4.5-fix-qa-boto3-requirement
branch
from
May 9, 2023 13:03
790f372
to
04d5621
Compare
nico-stefani
approved these changes
May 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the tests with
root@ip-172-31-82-0:/home/ubuntu/wazuh-qa/tests/integration/test_aws# pip freeze | grep boto
boto3==1.17.85
botocore==1.20.112
And these are the results
root@ip-172-31-82-0:/home/ubuntu/wazuh-qa/tests/integration/test_aws# pytest --disable-warnings --tb=line --tier 1 -x
================================================================================================ test session starts ================================================================================================
platform linux -- Python 3.10.6, pytest-7.1.2, pluggy-1.0.0
rootdir: /home/ubuntu/wazuh-qa/tests/integration, configfile: pytest.ini
plugins: metadata-2.0.4, html-3.1.1, testinfra-5.0.0
collected 195 items / 179 deselected / 16 selected
test_only_logs_after.py ..............x. [100%]
======================================================================= 15 passed, 179 deselected, 1 xfailed, 6 warnings in 362.85s (0:06:02) =======================================================================
root@ip-172-31-82-0:/home/ubuntu/wazuh-qa/tests/integration/test_aws# pytest --disable-warnings --tb=line --tier 0 -x
================================================================================================ test session starts ================================================================================================
platform linux -- Python 3.10.6, pytest-7.1.2, pluggy-1.0.0
rootdir: /home/ubuntu/wazuh-qa/tests/integration, configfile: pytest.ini
plugins: metadata-2.0.4, html-3.1.1, testinfra-5.0.0
collected 195 items / 16 deselected / 179 selected
test_basic.py ................ [ 8%]
test_discard_regex.py .............. [ 16%]
test_log_groups.py .. [ 17%]
test_only_logs_after.py ............................... [ 35%]
test_parser.py .......................... [ 49%]
test_path.py .......................................... [ 73%]
test_path_suffix.py ......... [ 78%]
test_regions.py ........................ [ 91%]
test_remove_from_bucket.py ...sss......... [100%]
====================================================================== 176 passed, 3 skipped, 16 deselected, 6 warnings in 3604.59s (1:00:04) =======================================================================
jnasselle
force-pushed
the
4.5-fix-qa-boto3-requirement
branch
from
May 11, 2023 11:46
04d5621
to
c24e533
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since Wazuh 4.5 and the Add AWS integration tests #3333 implementation,
boto3
python dependencies were added requesting a specific version that is not available on older/legacy OSThis PR aims to pair, at least, the requested version with the one integrated with the Wazuh Manager embedded Python interpreter
Added
Updated
boto3
version to be at least 1.17.85, the current version used here https://github.com/wazuh/wazuh/blob/4.5/framework/requirements.txt#L13-L14Deleted
Testing performed