Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regular_file_cud multiple changes in file #4183

Merged
merged 13 commits into from
May 30, 2023
Merged

Conversation

Deblintrake09
Copy link
Contributor

@Deblintrake09 Deblintrake09 commented May 17, 2023

Related issue
#4153

Description

This PR aims to fix the regular_file_cud helper function and the EventChecker that generate multiple modified file events, causing tests that depend on the function to fail.

Also, all tests that used the regular_file_cud function have been updated to use the updated version instead of the original version in the fim.py module.

Updated

  • Updated regular_file_cud in modules.fim.utils
  • Updated imports for regular_file_cud

Deleted

  • Removed old version of regular_file_cud and EventChecker from fim.py

Testing performed

Tester Test path Jenkins Local OS Commit Notes
@Deblintrake09 (Developer) test_fim 🟢🟢🟢 🟢🟢🟢 Manager b66a913 Nothing to highlight
@Deblintrake09 (Developer) test_fim 🟢🟢🟢 🟢🟢🟢 Linux Agent b66a913 Nothing to highlight
@Deblintrake09 (Developer) test_fim 🟢🟢🟢 ⚫⚫⚫ Windows Agent b66a913 Nothing to highlight
@Deblintrake09 (Developer) test_fim 🟢🟢🟢 🚫 🚫 🚫 Solaris & macOS b66a913 Nothing to highlight

@Deblintrake09 Deblintrake09 requested a review from damarisg May 17, 2023 19:50
@Deblintrake09 Deblintrake09 self-assigned this May 17, 2023
@Deblintrake09 Deblintrake09 linked an issue May 17, 2023 that may be closed by this pull request
@Deblintrake09 Deblintrake09 marked this pull request as ready for review May 17, 2023 21:55
@Deblintrake09 Deblintrake09 requested a review from Rebits May 24, 2023 12:35
@damarisg damarisg merged commit bf4a797 into 4.5 May 30, 2023
@damarisg damarisg deleted the 4153-fix-regular-file-cud branch May 30, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix modify_file function generating multiple events in Windows
3 participants