Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVD 2.0 Integration Test #4327

Merged
merged 7 commits into from
Jul 24, 2023
Merged

NVD 2.0 Integration Test #4327

merged 7 commits into from
Jul 24, 2023

Conversation

lsayanes
Copy link
Contributor

@lsayanes lsayanes commented Jul 18, 2023

Target version Related issue Related PR/dev branch
4.5.0 #4275 4275-NVD-2.0-ITs

Description

In this PR Vulnerability Detector integration tests that currently exist for the NVD provider have been modified.

Modifications

The update_from_year variable has been deleted from the vulnerability detector tests, and the following functions have been modified:

  • get_nvd_metadata_timestamp, feed_is_recently_updated, check_nvd_download_log, check_invalid_provider_update_from_year_log, test_validate_json_feed_content

  • The existing Feeds for the NVD have been modified for the new scheme:

    • custom_nvd_feed.json, custom_nvd_alternative_feed.json, real_nvd_feed.json

Note: The new feed structure expects a single line NVD feed - wazuh/wazuh#17954

  • The NVD provider configurations
    • configuration.yaml cases_update_from_year.yaml ossec.conf

Test

All tests in the test_vulnerability_detector folder have been executed successfully.
Here are the results: ITs.zip

@lsayanes lsayanes requested a review from MarcelKemp July 18, 2023 19:21
@MarcelKemp MarcelKemp changed the base branch from master to 4.5.0 July 18, 2023 20:08
@MarcelKemp MarcelKemp linked an issue Jul 18, 2023 that may be closed by this pull request
5 tasks
@MarcelKemp MarcelKemp force-pushed the 4275-NVD-2.0-ITs branch 2 times, most recently from 51681c2 to a468017 Compare July 19, 2023 10:29
@QU3B1M QU3B1M self-requested a review July 19, 2023 11:25
lsayanes pushed a commit that referenced this pull request Jul 19, 2023
lsayanes pushed a commit that referenced this pull request Jul 19, 2023
lsayanes pushed a commit that referenced this pull request Jul 19, 2023
MarcelKemp
MarcelKemp previously approved these changes Jul 19, 2023
Copy link
Member

@MarcelKemp MarcelKemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

QU3B1M
QU3B1M previously approved these changes Jul 19, 2023
@QU3B1M
Copy link
Member

QU3B1M commented Jul 19, 2023

LGTM!

@lsayanes lsayanes dismissed stale reviews from QU3B1M and MarcelKemp via 43d51b9 July 19, 2023 18:12
QU3B1M
QU3B1M previously approved these changes Jul 19, 2023
@Dwordcito Dwordcito merged commit ede149c into 4.5.0 Jul 24, 2023
@Dwordcito Dwordcito deleted the 4275-NVD-2.0-ITs branch July 24, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify the NVD's VD ITs support
5 participants