-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NVD 2.0 Integration Test #4327
Merged
Merged
NVD 2.0 Integration Test #4327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
MarcelKemp
force-pushed
the
4275-NVD-2.0-ITs
branch
2 times, most recently
from
July 19, 2023 10:29
51681c2
to
a468017
Compare
lsayanes
added a commit
that referenced
this pull request
Jul 19, 2023
lsayanes
pushed a commit
that referenced
this pull request
Jul 19, 2023
lsayanes
pushed a commit
that referenced
this pull request
Jul 19, 2023
lsayanes
pushed a commit
that referenced
this pull request
Jul 19, 2023
lsayanes
pushed a commit
that referenced
this pull request
Jul 19, 2023
lsayanes
force-pushed
the
4275-NVD-2.0-ITs
branch
from
July 19, 2023 15:38
a468017
to
c7aa30d
Compare
lsayanes
pushed a commit
that referenced
this pull request
Jul 19, 2023
MarcelKemp
force-pushed
the
4275-NVD-2.0-ITs
branch
from
July 19, 2023 16:10
c7aa30d
to
edff2b0
Compare
MarcelKemp
previously approved these changes
Jul 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
QU3B1M
previously approved these changes
Jul 19, 2023
LGTM! |
QU3B1M
previously approved these changes
Jul 19, 2023
MarcelKemp
force-pushed
the
4275-NVD-2.0-ITs
branch
from
July 20, 2023 10:33
43d51b9
to
7811dd6
Compare
MarcelKemp
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR Vulnerability Detector integration tests that currently exist for the NVD provider have been modified.
Modifications
The
update_from_year
variable has been deleted from the vulnerability detector tests, and the following functions have been modified:get_nvd_metadata_timestamp
,feed_is_recently_updated
,check_nvd_download_log
,check_invalid_provider_update_from_year_log
,test_validate_json_feed_content
The existing Feeds for the NVD have been modified for the new scheme:
custom_nvd_feed.json
,custom_nvd_alternative_feed.json
,real_nvd_feed.json
NVD
provider configurationsconfiguration.yaml
cases_update_from_year.yaml
ossec.conf
Test
All tests in the
test_vulnerability_detector
folder have been executed successfully.Here are the results: ITs.zip