-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix integrity sync test and config to avoid flaky behavior #4406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EduLeon12
force-pushed
the
fix/4368-fix-integrity-sync-system-test
branch
3 times, most recently
from
August 8, 2023 12:37
5e2e127
to
856b892
Compare
EduLeon12
pushed a commit
that referenced
this pull request
Aug 8, 2023
EduLeon12
force-pushed
the
fix/4368-fix-integrity-sync-system-test
branch
from
August 8, 2023 12:41
856b892
to
c899393
Compare
EduLeon12
changed the title
Increased max zip size limit and number of files created for integrit…
Fix integrity sync test and config to avoid flaky behavior
Aug 8, 2023
Selutario
suggested changes
Aug 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, the test still works in my env after the changes (unrelated tests were commented out to speed up the process):
$ pytest -vv test_integrity_sync
============================================================================================ test session starts =============================================================================================
platform linux -- Python 3.10.12, pytest-7.1.2, pluggy-1.0.0 -- /home/selu/venv/wazuh-qa/bin/python
cachedir: .pytest_cache
metadata: {'Python': '3.10.12', 'Platform': 'Linux-5.15.0-78-generic-x86_64-with-glibc2.35', 'Packages': {'pytest': '7.1.2', 'pluggy': '1.0.0'}, 'Plugins': {'html': '3.1.1', 'testinfra': '5.0.0', 'metadata': '2.0.4'}}
rootdir: /home/selu/Git/wazuh-qa/tests/system, configfile: pytest.ini
plugins: html-3.1.1, testinfra-5.0.0, metadata-2.0.4
collected 1 item
test_integrity_sync/test_integrity_sync.py::test_zip_size_limit PASSED [100%]
======================================================================================= 1 passed in 364.79s (0:06:04) ========================================================================================
However, updating the changelog is required.
EduLeon12
force-pushed
the
fix/4368-fix-integrity-sync-system-test
branch
from
August 9, 2023 10:38
f4a951c
to
6563b6a
Compare
EduLeon12
force-pushed
the
fix/4368-fix-integrity-sync-system-test
branch
from
August 9, 2023 10:41
592a044
to
749fb46
Compare
Selutario
approved these changes
Aug 9, 2023
LGTM Report: 4406.zip
|
Rebits
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
As explained in #4368 to fix the integrity sync test a change in the test had to be made to ensure the timeout occurs and expected and the
cancel_task
signals were properly received.Updated
tests/system/test_cluster/test_integrity_sync/test_integrity_sync.py
: changed number of files created from 5 to 10tests/system/test_cluster/test_integrity_sync/data/cluster_json.yml
: changed max zip size config from 50 MB to 100 MB.Testing performed
Failing System test were ran multiple times to confirm behavior.