Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade py dependency version for wazuh-qa when Python is in version 3.11 #4523

Merged
merged 6 commits into from
Sep 18, 2023

Conversation

verdx
Copy link
Contributor

@verdx verdx commented Sep 15, 2023

Related issue
https://github.com/wazuh/wazuh-jenkins/issues/5407

Description

When testing the changes in PR https://github.com/wazuh/wazuh-jenkins/pull/5342, it has been seen the tests fail with an error shown later if the dependency py is in version 1.10 instead of 1.11, as seen in pytest-dev/apipkg#30.

Updated

  • requirements.txt

Testing performed

The test fails on some fim tests, but it is expected, as running it using branch 4.5.3 also fails with it.

Tester Test path Jenkins Local OS Commit Notes
@user (Developer) 🟢 ⚫⚫⚫ Nothing to highlight
@user (Reviewer) ⚫⚫⚫ 🚫 🚫 🚫 Nothing to highlight

@verdx verdx self-assigned this Sep 15, 2023
@verdx
Copy link
Contributor Author

verdx commented Sep 15, 2023

The rest of the updates of this PR are reflected on issue https://github.com/wazuh/wazuh-jenkins/issues/5407, as there are two different PRs and the updates are common.

The testing on why this PR can be merged can be found in the last commentary in the issue.

Copy link
Member

@damarisg damarisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the CHANGELOG file

@verdx
Copy link
Contributor Author

verdx commented Sep 18, 2023

Please add the CHANGELOG file

@damarisg Done in 7780af6

@verdx verdx requested a review from damarisg September 18, 2023 07:55
CHANGELOG.md Outdated Show resolved Hide resolved
@verdx verdx requested a review from juliamagan September 18, 2023 08:29
Copy link
Member

@juliamagan juliamagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliamagan juliamagan merged commit 7587ec3 into 4.5.3 Sep 18, 2023
@juliamagan juliamagan deleted the enhacement/3788-upgrade-windows-it-ami branch September 18, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants