Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in the system testing container #4686

Merged

Conversation

pro-akim
Copy link
Member

@pro-akim pro-akim commented Nov 9, 2023

Related issue
#4682

Description

Previous containers had performance problems. It could be related to its size (around 9gbs).
It will revert changes and It will be important to run the tests using package method:

ansible-playbook -i inventory.yml playbook.yml --extra-vars='{"package_repository":"packages", "repository": "4.x", "package_version": "4.4.0", "package_revision": "1"}'

Updated

  • Reverse to previous containers
  • Provisioning by repository is deprecated

Testing performed

Tester Test path Jenkins Local OS Commit Notes
@pro-akim (Developer) ⚫⚫⚫ 🟢🟢🟢 Nothing to highlight
@user (Reviewer) ⚫⚫⚫ 🚫 🚫 🚫 Nothing to highlight

@pro-akim
Copy link
Member Author

Update:

Linting errors are not related with recent changes.

Copy link
Member

@Rebits Rebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes are required:

  • Deprecate temporally the source installation
  • Address the instability in certain Docker environments in an issue

Source Installation Deprecation:

If the source installation always fail from 4.7.0 due to the gcc image, let's consider deprecating it from the playbook temporary. This would streamline the deployment process, allowing only the use of the packages option.

Container Sensitivity:

Regarding this comment, it's clear that Wazuh, not the tests, exhibits sensitivity to container environments. Notably, Syscheck alerts are selectively generated based on the environment. Proposing to open a new issue to thoroughly investigate this behavior and ensure Wazuh's seamless operation across various environments. The goal is to make Wazuh adaptable, regardless of image size.

@pro-akim
Copy link
Member Author

Update

A new issue has been opened: wazuh/wazuh#20191 regarding the sensitivity of Wazuh in certain containers.

@pro-akim
Copy link
Member Author

Update

Install by repository has been deprecated.
3 different environments were tested and reports are attached in the general report

Linting errors are not related to changed code.

@pro-akim pro-akim requested a review from Rebits November 13, 2023 11:12
CHANGELOG.md Outdated
@@ -20,6 +20,7 @@ All notable changes to this project will be documented in this file.

### Fixed

- Fix of system test instability ([#4686](https://github.com/wazuh/wazuh-qa/pull/4686)) \- (Tests)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fix of system test instability ([#4686](https://github.com/wazuh/wazuh-qa/pull/4686)) \- (Tests)
- Deprecate source installation in System Tests ([#4686](https://github.com/wazuh/wazuh-qa/pull/4686)) \- (Framework)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in d98e795

@pro-akim pro-akim requested a review from Rebits November 13, 2023 11:34
Copy link
Member

@Rebits Rebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidjiglesias davidjiglesias merged commit 85759fe into 4.7.0 Nov 13, 2023
3 of 4 checks passed
@davidjiglesias davidjiglesias deleted the bug/4682-One_manager_agent_environment_test_failure branch November 13, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

One Manager Agent environment in the system test has exhibited instability in its results
3 participants