Additional Vulnerability Detection E2E tests #5287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliamagan
requested changes
Apr 29, 2024
There was a problem hiding this comment.
GJ!
We should check the docstrings of the functions, many do not have them and others do not follow the same format among themselves.
In addition, we should also check the logging level, since it can be confusing that info or debug logs are critical or error.
tests/end_to_end/test_vulnerability_detector/test_vulnerability_detector.py
Outdated
Show resolved
Hide resolved
tests/end_to_end/test_vulnerability_detector/test_vulnerability_detector.py
Outdated
Show resolved
Hide resolved
tests/end_to_end/test_vulnerability_detector/test_vulnerability_detector.py
Outdated
Show resolved
Hide resolved
tests/end_to_end/test_vulnerability_detector/test_vulnerability_detector.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Julia Magan <juliamgnr@gmail.com>
Co-authored-by: Julia Magan <juliamgnr@gmail.com>
Co-authored-by: Julia Magan <juliamgnr@gmail.com>
Co-authored-by: Julia Magan <juliamgnr@gmail.com>
Co-authored-by: Julia Magan <juliamgnr@gmail.com>
Co-authored-by: Julia Magan <juliamgnr@gmail.com>
Co-authored-by: Julia Magan <juliamgnr@gmail.com>
Co-authored-by: Julia Magan <juliamgnr@gmail.com>
Co-authored-by: Julia Magan <juliamgnr@gmail.com>
Co-authored-by: Julia Magan <juliamgnr@gmail.com>
Co-authored-by: Julia Magan <juliamgnr@gmail.com>
Co-authored-by: Julia Magan <juliamgnr@gmail.com>
Co-authored-by: Julia Magan <juliamgnr@gmail.com>
Co-authored-by: Julia Magan <juliamgnr@gmail.com>
|
Applied requested changes. Currently testing in real environment |
juliamagan
requested changes
Apr 30, 2024
Comment on lines
294
to
295
| windows: | ||
| amd64: node-v19.5.0 |
There was a problem hiding this comment.
Although there is a commit that changes the package, it still shows 19.5.0
Co-authored-by: Julia Magan <juliamgnr@gmail.com>
juliamagan
previously approved these changes
Apr 30, 2024
juliamagan
approved these changes
Apr 30, 2024
This was referenced Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes additional Vulnerability Detection tests along with a Vulnerability Detector E2E refactor to improve report reliability and readability
Testing performed
Report