Update comments in CIS benchmarks yml files #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chemamartinez
approved these changes
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Team,
This PR fixes mainly some typos in the CIS benchmarks yml file for RedHat 6 and 7.
Not all the paragraph numbers in the comments match the
cis:fields values. Said comments are updated with thesecis:values.Also, some checks in
cis_rhel6_linux_rcl.ymlandcis_rhel7_linux_rcl.ymlare not present in the PDF files for RedHat 6 and RedHat 7. They exist for RedHat 5, but not for higher versions.Remove these checks in the yml files for RedHat 6 and 7 (RedHat 5 yml file stays the same). Consequently update the
id:fields, since a couple of checks have disappeared.Regards.