Add restrictive filters for every channel and provider name filter. #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chemamartinez
suggested changes
May 16, 2019
rules/0605-win-mcafee_rules.xml
Outdated
| @@ -42,34 +42,34 @@ | |||
|
|
|||
| <rule id="62603" level="2"> | |||
| <if_sid>62600</if_sid> | |||
| <field name="win.system.eventID">$MCAFEE_INFO</field> | |||
| <field name="win.system.eventID">$MCAFEE_INFO$</field> | |||
There was a problem hiding this comment.
$MCAFEE_INFO is a variable defined as <var name="MCAFEE_INFO">^257$|^5000$|^5026$|^5052$|^5055$</var> so it is not needed to include the $ character.
rules/0605-win-mcafee_rules.xml
Outdated
| <description>McAfee Windows AV informational event</description> | ||
| </rule> | ||
|
|
||
| <rule id="62604" level="3"> | ||
| <if_sid>62601</if_sid> | ||
| <field name="win.system.eventID">$MCAFEE_WARN</field> | ||
| <field name="win.system.eventID">$MCAFEE_WARN$</field> |
rules/0605-win-mcafee_rules.xml
Outdated
| <description>McAfee Windows AV warning event</description> | ||
| <group>gpg13_4.12,</group> | ||
| </rule> | ||
|
|
||
| <rule id="62605" level="4"> | ||
| <if_sid>62602</if_sid> | ||
| <field name="win.system.eventID">$MCAFEE_ERROR</field> | ||
| <field name="win.system.eventID">$MCAFEE_ERROR$</field> |
rules/0605-win-mcafee_rules.xml
Outdated
| <description>McAfee Windows AV error event</description> | ||
| <group>gpg13_4.3,</group> | ||
| </rule> | ||
|
|
||
| <rule id="62606" level="12"> | ||
| <if_sid>62600,62601,62602</if_sid> | ||
| <field name="win.system.message">$MCAFEE_VIRUS</field> | ||
| <field name="win.system.message">$MCAFEE_VIRUS$</field> |
rules/0605-win-mcafee_rules.xml
Outdated
| <group>virus,pci_dss_5.1,pci_dss_5.2,pci_dss_10.6.1,pci_dss_11.4,gpg13_4.2,gdpr_IV_35.7.d,</group> | ||
| <description>McAfee Windows AV - Virus detected and not removed</description> | ||
| </rule> | ||
|
|
||
| <rule id="62607" level="7"> | ||
| <if_sid>62606</if_sid> | ||
| <field name="win.system.message">$MCAFEE_VIRUS_OK</field> | ||
| <field name="win.system.message">$MCAFEE_VIRUS_OK$</field> |
chemamartinez
approved these changes
May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue #401. It adds restrictive characters for every channel and provider name filter.