Test Kafka 0.8.2.2 using Python 3.10 in the meantime #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Definitely will need to go back and revert this PR someday, I don't want to make the CI/CD too messy. |
|
Passes on 3.10 but on kafka-python I managed to get it passing on 3.11. Something else is going on here. |
wbarnha
changed the title
|
So something must've been introduced in 3.11 that broke compatibility with 0.8.2.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 3.12 can't support Kafka v0.8.2.2 at the moment, but we know older versions of Python can, let's try to use an earlier version just to make sure we don't break anything for users until we document it.