Remove all vendoring #169
Remove all vendoring #169
Conversation
|
I coincidentally ran |
|
I'm braced and ready for doing the rebase. :-) |
You responded as I was opening this PR. This is going to be a chunky one to rebase, I'll get around to merging it tomorrow |
|
Yeah, I suspect it is going to be easier to carry over the vendor removal bits I want, and drop every other change. I can probably sort that out in the next 30 minutes if you wish. |
If you could, that would be great! I'm pretty eager to get this merged. |
Now that the codebase has been modernised by using pyupgrade, we can also remove all backported vendor modules, and all uses of them.
s-t-e-v-e-n-k
force-pushed
the
remove-vendoring
branch
from
3631a8c to
d505f5e
Compare
|
Forced pushed, let's see if I missed anything. I'm not 100% happy with the crimes I committed in |
| def int2byte(i): | ||
| return bytes((i),) | ||
|
|
There was a problem hiding this comment.
Forced pushed, let's see if I missed anything. I'm not 100% happy with the crimes I committed in
benchmarks/variant_speed.py, but I also didn't want to completely rewrite it to remove its reliance on the Python 2 construct of int2byte.
It happens, it's a sacrifice that sometimes must be made to keep the ball rolling 😅
With this project removing support for Python 2 as well as any version of Python 3 that is < 3.8, utilise pyupgrade to bring this project to that level of Python 3 code, as well as removing all vestiges of vendored backports.