Update subscription patterns to automatically convert strs to bytes #3
Conversation
![code-review-doctor[bot]](https://avatars.githubusercontent.com/in/83430?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks good. Worth considering though. View full project report here.
| @@ -37,7 +37,7 @@ | |||
|
|
|||
| def publish(): | |||
| data = str(time.time()) | |||
| print "publishing %r" % data | |||
| print("publishing %r" % data) | |||
There was a problem hiding this comment.
f-string is easier to read, write, and less computationally expensive than legacy string formatting. More.
| @@ -48,7 +48,7 @@ def publish(): | |||
| s.subscribe("") | |||
|
|
|||
| def doPrint(*args): | |||
| print "message received: %r" % (args, ) | |||
| print("message received: %r" % (args, )) | |||
There was a problem hiding this comment.
As above, Consider using f-string instead.
| @@ -41,11 +41,11 @@ | |||
|
|
|||
| def produce(): | |||
| data = [str(time.time()), socket.gethostname()] | |||
| print "producing %r" % data | |||
| print("producing %r" % data) | |||
There was a problem hiding this comment.
f-string is easier to read, write, and less computationally expensive than legacy string formatting. More details.
| @@ -54,7 +54,7 @@ def produce(): | |||
| s = ZmqPullConnection(zf, e) | |||
|
|
|||
| def doPrint(message): | |||
| print "consuming %r" % (message,) | |||
| print("consuming %r" % (message,)) | |||
There was a problem hiding this comment.
As above, Consider using f-string instead.
| @@ -40,7 +40,7 @@ def produce(): | |||
| # data = [str(time.time()), socket.gethostname()] | |||
| data = str(time.time()) | |||
|
|
|||
| print "Requesting %r" % data | |||
| print("Requesting %r" % data) | |||
There was a problem hiding this comment.
f-string is easier to read, write, and less computationally expensive than legacy string formatting. Read more.
| @@ -63,7 +63,7 @@ def onTimeout(fail): | |||
| s = ZmqREPConnection(zf, e) | |||
|
|
|||
| def doPrint(messageId, message): | |||
| print "Replying to %s, %r" % (messageId, message) | |||
| print("Replying to %s, %r" % (messageId, message)) | |||
There was a problem hiding this comment.
As above, Consider using f-string instead.
wbarnha
changed the title
No description provided.