Skip to content

Commit

Permalink
don't panic for unsupported messages (#108)
Browse files Browse the repository at this point in the history
Co-authored-by: Wil Boayue <wboayue@gmail.com>
  • Loading branch information
wboayue and Wil Boayue committed Sep 15, 2023
1 parent 4e677fd commit 058cee2
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "ibapi"
version = "0.4.0"
version = "0.4.1"
edition = "2021"
authors = ["Wil Boayue <wil@wsbsolutions.com>"]
description = "A synchronous implementation of the Interactive Brokers TWS API."
Expand Down
2 changes: 2 additions & 0 deletions src/client/transport.rs
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,8 @@ fn process_response(requests: &Arc<SenderHash<i32, ResponseMessage>>, orders: &A
requests.send(&request_id, message).unwrap();
} else if orders.contains(&request_id) {
orders.send(&request_id, message).unwrap();
} else {
info!("no recipient found for: {:?}", message)
}
}

Expand Down
6 changes: 5 additions & 1 deletion src/messages.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
use std::ops::Index;
use std::str::{self, FromStr};

use log::error;
use time::OffsetDateTime;

use crate::{Error, ToField};
Expand Down Expand Up @@ -209,7 +210,10 @@ pub fn request_id_index(kind: IncomingMessages) -> Option<usize> {
| IncomingMessages::HistoricalTickBidAsk
| IncomingMessages::HistoricalTickLast => Some(1),
IncomingMessages::ContractDataEnd | IncomingMessages::RealTimeBars | IncomingMessages::Error | IncomingMessages::ExecutionDataEnd => Some(2),
_ => panic!("could not determine request id index for {kind:?}"),
_ => {
error!("could not determine request id index for {kind:?}");
None
},
}
}

Expand Down
1 change: 0 additions & 1 deletion src/messages/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,6 @@ fn test_request_id_index() {
}

#[test]
#[should_panic]
fn test_request_id_index_invalid() {
assert_eq!(request_id_index(IncomingMessages::NotValid), None);
}

0 comments on commit 058cee2

Please sign in to comment.