Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wbolster#45 #46

Merged
merged 1 commit into from
Jun 7, 2019
Merged

fix wbolster#45 #46

merged 1 commit into from
Jun 7, 2019

Conversation

bricewge
Copy link
Contributor

@bricewge bricewge commented Jun 1, 2019

file-directory-p try to initiate a connection so I moved the file-remote-p before it.

@wbolster
Copy link
Owner

wbolster commented Jun 7, 2019

wow, nice debugging since this is non obvious 👍

while at it, any chance you can move the string-equals-p up (right after the non-nil check) so that this cheap check runs before the (potentially slower) file path checks?

@bricewge
Copy link
Contributor Author

bricewge commented Jun 7, 2019

Is it better now?

@wbolster
Copy link
Owner

wbolster commented Jun 7, 2019

thanks!

@wbolster wbolster merged commit 5633ba2 into wbolster:master Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants