Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SAS Programming package #5571

Merged
merged 5 commits into from
Jun 20, 2016
Merged

Added SAS Programming package #5571

merged 5 commits into from
Jun 20, 2016

Conversation

rpardee
Copy link
Contributor

@rpardee rpardee commented Jun 5, 2016

Thanks very much!

@rpardee rpardee mentioned this pull request Jun 5, 2016
"releases": [
{
"sublime_text": ">=3000",
"tags": true
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and the two lines above all should be indented one more level.

@wbond
Copy link
Owner

wbond commented Jun 13, 2016

Snippets should use the tab character for indentation. If the user has specified indentation should happen via spaces, Sublime Text will convert the tabs to the appropriate number of spaces.

@wbond
Copy link
Owner

wbond commented Jun 13, 2016

I believe you should be able to use the built-in built system error navigation. You need to specify the regex to search for as a setting on the view named result_file_regex. You can see an example at https://github.com/golang/sublime-build/blob/master/golang_build.py#L958.

@FichteFoll
Copy link
Collaborator

Or refer to some docs.

@wbond
Copy link
Owner

wbond commented Jun 13, 2016

@FichteFoll It would be nice if you guys killed http://sublimetext.info/docs/en/ and forward it to relevant info.

@FichteFoll
Copy link
Collaborator

Agree. cc @guillermooo

@rpardee
Copy link
Contributor Author

rpardee commented Jun 17, 2016

Thanks much for the feedback! I have fixed the snippets (and hopefully the indentation now too).

I'm unclear on the error nav though--build results get written to a separate .log file on disk, rather than come back from stdout, say. So that file gets opened independently & is not a "results view", I don't think. (At any rate, if I open one of these guys, the command palette doesn't show a 'next error' command, and hitting F4 doesn't give me any error or warning in the console--just does nothing.)

You buy that?

Thanks again!

@FichteFoll
Copy link
Collaborator

Besides the logging output, this is pretty much exactly what the default build system target, the exec command, does. You can check its implementation in Default/exec.py. You can also refer to that for the result_file_regex setting.

@FichteFoll FichteFoll merged commit 31d0f80 into wbond:master Jun 20, 2016
@rpardee
Copy link
Contributor Author

rpardee commented Jun 20, 2016

Very cool--thanks! I'll have a look at exec.py & see what I can see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants