Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PanePane package to default channel #6056

Merged
merged 1 commit into from
Jan 19, 2017
Merged

Add PanePane package to default channel #6056

merged 1 commit into from
Jan 19, 2017

Conversation

mikesmithgh
Copy link
Contributor

Please provide the following information:

Also make sure you:

  1. Used "tags": true and not "branch": "master" (versioning docs)
  2. Ran the tests (tests docs)

@FichteFoll
Copy link
Collaborator

FichteFoll commented Jan 16, 2017

Report for panepane

Repository checks

No failures

No warnings

Package checks

Reporting 1 failures:

  • The binding ['super+,'] unconditionally overrides a default binding
    File: Default (OSX).sublime-keymap

No warnings

For more details on the report messages (for example how to resolve them), go to:
https://github.com/packagecontrol/package_reviewer/wiki


Looks interesting. As I recently switched to i3wm, you might want to check out mode-switching where you enter resize-mode on a certain key-press and then have different key bindings active until you make the context not match anymore (e.g. after pressing Esc).

As a personal suggestion, you might want to check out https://github.com/SublimeText/InactivePanes.

@mikesmithgh
Copy link
Contributor Author

@FichteFoll Thank you for the info. I didn't realize I should run package_reviewer. I just pulled that down and adjusted the osx keybindings. The tests passed on my latest tag, so it shouldn't override the defaults anymore. InactivePanes is a nice touch, I decided to update my demo and add that to my readme recommended pugins. It saves my eyes from hunting down that little cursor :). I haven't played around with i3wm so I may need to give that a shot. I have been using terminator for split screen in my terminal, it may be of interest to you https://gnometerminator.blogspot.com/p/introduction.html.

I like the idea of having a resize mode, so I may add that feature in the future. Thanks for the feedback!

Please let me know if anything else should be done to have this PR merged to master.

@FichteFoll
Copy link
Collaborator

FichteFoll commented Jan 19, 2017

I wrote package_reviewer only a few weeks ago to help with the package review process, so it isn't mentioned anywhere at the moment.

@FichteFoll FichteFoll merged commit 4bccddc into wbond:master Jan 19, 2017
taylorzane pushed a commit to adelyte/package_control_channel that referenced this pull request Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants