Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump elasticsearch from 8.9.2 to 8.10.2 in /examples/skywalking #1051

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/skywalking/Dockerfile-elasticsearch
Original file line number Diff line number Diff line change
@@ -1 +1 @@
FROM elasticsearch:8.9.2@sha256:38082e945768e8e98fc0d828c810baf0b63d58ddc9059db2a62e4c293e44e817
FROM elasticsearch:8.10.2@sha256:53efb4ba72e1c71c8223ee8d8de6537e8d992ad6cc8fcdf5dd944be93b6ab814
70 changes: 0 additions & 70 deletions source/common/upstream/upstream_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -863,74 +863,6 @@ ClusterInfoImpl::generateTimeoutBudgetStats(Stats::Scope& scope,
return {stat_names, scope};
}

// Implements the FactoryContext interface required by network filters.
class FactoryContextImpl : public Server::Configuration::CommonFactoryContext {
public:
// Create from a TransportSocketFactoryContext using parent stats_scope and runtime
// other contexts taken from TransportSocketFactoryContext.
FactoryContextImpl(Stats::Scope& stats_scope, Envoy::Runtime::Loader& runtime,
Server::Configuration::TransportSocketFactoryContext& c)
: admin_(c.serverFactoryContext().admin()),
server_scope_(c.serverFactoryContext().serverScope()), stats_scope_(stats_scope),
cluster_manager_(c.clusterManager()), local_info_(c.serverFactoryContext().localInfo()),
dispatcher_(c.serverFactoryContext().mainThreadDispatcher()), runtime_(runtime),
singleton_manager_(c.serverFactoryContext().singletonManager()),
tls_(c.serverFactoryContext().threadLocal()), api_(c.serverFactoryContext().api()),
options_(c.serverFactoryContext().options()),
message_validation_visitor_(c.messageValidationVisitor()) {}

Upstream::ClusterManager& clusterManager() override { return cluster_manager_; }
Event::Dispatcher& mainThreadDispatcher() override { return dispatcher_; }
const Server::Options& options() override { return options_; }
const LocalInfo::LocalInfo& localInfo() const override { return local_info_; }
Envoy::Runtime::Loader& runtime() override { return runtime_; }
Stats::Scope& scope() override { return stats_scope_; }
Stats::Scope& serverScope() override { return server_scope_; }
Singleton::Manager& singletonManager() override { return singleton_manager_; }
ThreadLocal::SlotAllocator& threadLocal() override { return tls_; }
OptRef<Server::Admin> admin() override { return admin_; }
TimeSource& timeSource() override { return api().timeSource(); }
ProtobufMessage::ValidationContext& messageValidationContext() override {
// TODO(davinci26): Needs an implementation for this context. Currently not used.
PANIC("unimplemented");
}

AccessLog::AccessLogManager& accessLogManager() override {
// TODO(davinci26): Needs an implementation for this context. Currently not used.
PANIC("unimplemented");
}

ProtobufMessage::ValidationVisitor& messageValidationVisitor() override {
return message_validation_visitor_;
}

Server::ServerLifecycleNotifier& lifecycleNotifier() override {
// TODO(davinci26): Needs an implementation for this context. Currently not used.
PANIC("unimplemented");
}

Init::Manager& initManager() override {
// TODO(davinci26): Needs an implementation for this context. Currently not used.
PANIC("unimplemented");
}

Api::Api& api() override { return api_; }

private:
OptRef<Server::Admin> admin_;
Stats::Scope& server_scope_;
Stats::Scope& stats_scope_;
Upstream::ClusterManager& cluster_manager_;
const LocalInfo::LocalInfo& local_info_;
Event::Dispatcher& dispatcher_;
Envoy::Runtime::Loader& runtime_;
Singleton::Manager& singleton_manager_;
ThreadLocal::SlotAllocator& tls_;
Api::Api& api_;
const Server::Options& options_;
ProtobufMessage::ValidationVisitor& message_validation_visitor_;
};

std::shared_ptr<const ClusterInfoImpl::HttpProtocolOptionsConfigImpl>
createOptions(const envoy::config::cluster::v3::Cluster& config,
std::shared_ptr<const ClusterInfoImpl::HttpProtocolOptionsConfigImpl>&& options,
Expand Down Expand Up @@ -1066,8 +998,6 @@ ClusterInfoImpl::ClusterInfoImpl(
server_context)),
network_filter_config_provider_manager_(
createSingletonUpstreamNetworkFilterConfigProviderManager(server_context)),
factory_context_(
std::make_unique<FactoryContextImpl>(*stats_scope_, runtime, factory_context)),
upstream_context_(server_context, init_manager, *stats_scope_),
per_connection_buffer_limit_bytes_(
PROTOBUF_GET_WRAPPED_OR_DEFAULT(config, per_connection_buffer_limit_bytes, 1024 * 1024)),
Expand Down
1 change: 0 additions & 1 deletion source/common/upstream/upstream_impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -1094,7 +1094,6 @@ class ClusterInfoImpl : public ClusterInfo,
std::shared_ptr<Http::UpstreamFilterConfigProviderManager> http_filter_config_provider_manager_;
std::shared_ptr<UpstreamNetworkFilterConfigProviderManager>
network_filter_config_provider_manager_;
const std::unique_ptr<Server::Configuration::CommonFactoryContext> factory_context_;
Filter::NetworkFilterFactoriesList filter_factories_;
Http::FilterChainUtility::FilterFactoriesList http_filter_factories_;
mutable Http::Http1::CodecStats::AtomicPtr http1_codec_stats_;
Expand Down