chore (closes #49): added basic ESLint support #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@BlackSonic, can you please have a look on this one? |
sonicoder86
reviewed
Nov 29, 2016
| @@ -1,3 +1,4 @@ | |||
| /* eslint-env mocha */ | |||
There was a problem hiding this comment.
Can we move this to config rather than comment in code?
There was a problem hiding this comment.
Do you mean having separate configuration for tests and sources?
Mocha is used only in tests, that's why I put it via comment in spec file.
There was a problem hiding this comment.
No, it is completely fine, to put it into one configuration file.
Adding comments does not scale if we will have multiple spec files.
There was a problem hiding this comment.
@BlackSonic , done
CynoteckAngularJs2
approved these changes
Nov 30, 2016
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.